[
https://issues.apache.org/jira/browse/CB-13115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101479#comment-16101479
]
ASF GitHub Bot commented on CB-13115:
-------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/56
CB-13115 (browser) Fixed getCurrentAcceleration() on Firefox, Safari …
…and Edge
### Platforms affected
Browser
### What does this PR do?
https://issues.apache.org/jira/browse/CB-13115
Makes getCurrentAcceleration() properly fire a `devicemotion` event on some
browsers
### What testing has been done on this change?
Manual and automatic testing
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alsorokin/cordova-plugin-device-motion
CB-13115
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device-motion/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit c9642ff2a1a02a079a264e9ec4fe83ce2a126e77
Author: Alexander Sorokin <[email protected]>
Date: 2017-07-26T10:06:40Z
CB-13115 (browser) Fixed getCurrentAcceleration() on Firefox, Safari and
Edge
----
> accelerometer.getCurrentAcceleration() doesn't work on Firefox, Safari and
> Edge
> -------------------------------------------------------------------------------
>
> Key: CB-13115
> URL: https://issues.apache.org/jira/browse/CB-13115
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-device-motion
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
>
> https://travis-ci.org/apache/cordova-plugin-device-motion/builds/257642867?utm_source=github_status&utm_medium=notification
> Here's some related test failures:
> {noformat}
> 1) cordova-plugin-device-motion-tests.tests >> Accelerometer
> (navigator.accelerometer) getCurrentAcceleration accelerometer.spec.3 success
> callback should be called with an Acceleration object
> - Error: Timeout - Async callback was not invoked within timeout specified
> by jasmine.DEFAULT_TIMEOUT_INTERVAL. in
> http://localhost:8000/cdvtests/jasmine-2.4.1/jasmine.js (line 1909)
> 2) cordova-plugin-device-motion-tests.tests >> Accelerometer
> (navigator.accelerometer) getCurrentAcceleration accelerometer.spec.4 success
> callback Acceleration object should have (reasonable) values for x, y and z
> expressed in m/s^2
> - Error: Timeout - Async callback was not invoked within timeout specified
> by jasmine.DEFAULT_TIMEOUT_INTERVAL. in
> http://localhost:8000/cdvtests/jasmine-2.4.1/jasmine.js (line 1909)
> 3) cordova-plugin-device-motion-tests.tests >> Accelerometer
> (navigator.accelerometer) getCurrentAcceleration accelerometer.spec.5 success
> callback Acceleration object should return a recent timestamp
> - Error: Timeout - Async callback was not invoked within timeout specified
> by jasmine.DEFAULT_TIMEOUT_INTERVAL. in
> http://localhost:8000/cdvtests/jasmine-2.4.1/jasmine.js (line 1909)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
