[ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110878#comment-16110878
 ] 

ASF GitHub Bot commented on CB-3232:
------------------------------------

GitHub user adirel opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/235

    Download permissions

    <!--
    Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
    is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jonasof/cordova-plugin-inappbrowser 
download-permissions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #235
    
----
commit 4063179c35bbd6c4bd1f3deaef005fd2c95fe36b
Author: Gorebar <alb...@telefonica.net>
Date:   2016-12-12T11:49:19Z

    (Android) Implement Download Files from URL on Android WebView.

commit 45214911cbeb3268f98e0a64081ec80732829659
Author: Gorebar <alb...@telefonica.net>
Date:   2016-12-12T11:57:28Z

    Change Toast.

commit 358b6804b2bd96d900daa0f6cc964169205ae400
Author: Gorebar <alb...@telefonica.net>
Date:   2016-12-12T12:49:51Z

    Add imports

commit 162a81eb86b15ecfaea612971c89a87e025df534
Author: Mèir Noordermeer <m.noorderm...@genkgo.nl>
Date:   2017-03-20T11:47:16Z

    Merge branch 'master' of 
https://github.com/Gorebar/cordova-plugin-inappbrowser

commit c56232f31e520f9e9ebedb699b7fa0ad35e23000
Author: Mèir Noordermeer <m.noorderm...@genkgo.nl>
Date:   2017-03-20T15:03:35Z

    Catch errors when user has not given storage permissions on Android

commit 7b6700ab2344b1321045403db2e85bda086c2792
Author: Mèir Noordermeer <m.noorderm...@genkgo.nl>
Date:   2017-03-20T15:51:15Z

    Add isStoragePermissionGranted to DownloadListener and catch 
DownloadManager errors

commit f0cc7c4ee7473fbda29cf9a51db362ff7380e0cf
Author: Jonas Oliveira <cont...@jonasof.com.br>
Date:   2017-04-14T15:07:41Z

    External Storage permissions to AndroidManifest.xml
    
    Without this the plugin cannot ask for user permissions

commit aaaaa72880146f4c74d51d1379baef501e935ec5
Author: Jonas Oliveira <cont...@jonasof.com.br>
Date:   2017-04-14T15:15:23Z

    Download file immediately after user authorize
    
    Currently the user needs to click again do download after he authorizes
    file privilegies, so I create a new class to handle the download code,
    saving to memory (via class proprieties) the download url and other info
    and handling the callback "onRequestPermissionResult"
    
    I also have changed the requester to "cordova.requestPermission", maybe
    this has compatibility problems with older versions of cordova or
    cordova-android.

commit 4ea9e4f747d79cd6a97e49f5801b9177465bd3ab
Author: Jonas Oliveira <cont...@jonasof.com.br>
Date:   2017-04-14T16:05:09Z

    Change download folder to system default, instead of cache

----


> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -----------------------------------------------------
>
>                 Key: CB-3232
>                 URL: https://issues.apache.org/jira/browse/CB-3232
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-blackberry (DEPRECATED), cordova-cli
>    Affects Versions: 2.7.0
>            Reporter: Michael Brooks
>            Assignee: Michael Brooks
>             Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to