[
https://issues.apache.org/jira/browse/CB-12339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131447#comment-16131447
]
ASF GitHub Bot commented on CB-12339:
-------------------------------------
GitHub user albertolalama opened a pull request:
https://github.com/apache/cordova-osx/pull/39
CB-12339: handle re-open app window
### Platforms affected
osx
### What does this PR do?
When the app icon in the dock is clicked: re-opens the app window when if
the app is closed. Brings the app window to the front if the app is running.
### What testing has been done on this change?
Manual verification.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
* I don't have much experience testing UX. Would like pointers if tests
are required for this feature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/albertolalama/cordova-osx alalama-reopen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-osx/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit cc156f86ab4d11643703f41e1643882a9d5d8e63
Author: alberto lalama <[email protected]>
Date: 2017-08-17T22:55:24Z
CB-12339: handle re-open app window
----
> On OS X platform, closing the main window leaves the app open but you can't
> restore the main view
> -------------------------------------------------------------------------------------------------
>
> Key: CB-12339
> URL: https://issues.apache.org/jira/browse/CB-12339
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-osx
> Affects Versions: 6.4.0
> Environment: macOS Sierra
> Reporter: Paul Connolley
> Assignee: Tobias Bocanegra
> Priority: Minor
>
> (I do apologise if this is covered in the documentation but I couldn't find
> any mention of it anywhere. Also, this is my first ticket here so I apologise
> if I'm putting this in the wrong place!)
> 1. I created a new Cordova app and added the osx platform (cordova platform
> add osx) and then ran `cordova run osx`.
> 2. The app built with no problems and launched the app.
> 3. I then clicked the 'close' button on the app and it closed the main window
> 4. Then I clicked the app icon in the dock - expecting it to restore the main
> window - but nothing happened.
> This seems a little odd but I'd have expected either:
> * The app to close when clicking the close button; or
> * The window to be restored after clicking the dock icon
> Ideally, it'd be lovely if there was a way to decide which of the above
> behaviours was available. At the least, I'd probably expect one of these as a
> default.
> Any help would be appreciated here. If I'm being dim and it's in the
> documentation, my apologies!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
