[
https://issues.apache.org/jira/browse/CB-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140491#comment-16140491
]
ASF GitHub Bot commented on CB-13145:
-------------------------------------
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/590
CB-13145: Create playservices version preference in config.xml
Still need to add in tests
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
CB-13145: Create playservices version preference in config.xml
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-13145-Steve
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/590.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #590
----
commit 315e6a80b95a425a07a0a32e53e24ce10e1ef89c
Author: Steve Gill <[email protected]>
Date: 2017-08-23T04:39:24Z
CB-13145: pass full options to plugman uninstall
commit faa48e255fc02dd42f2bcc7eaa43f816967305cb
Author: Audrey So <[email protected]>
Date: 2017-08-23T20:27:45Z
CB-13145 : added variable-merge.js to deal with plugin.xml variables for
uninstall
----
> Create playservices version preference in config.xml
> ----------------------------------------------------
>
> Key: CB-13145
> URL: https://issues.apache.org/jira/browse/CB-13145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
> Reporter: Steve Gill
> Labels: backlog, tools-next
> Fix For: [email protected]
>
>
> We are seeing an issue in the community of two plugins using different
> versions of google play services. This causes gradle to error out. We are
> running into this with the phonegap-push-plugin.
> Potential solution:
> We could create an Android only preference called PlayServicesVersion in
> config.xml which would control the version of Play Services used for the
> entire project.
> In config.xml:
> {code}
> <preference name="PlayServicesVersion" value="11.0.1"/>
> {code}
> Then if the push plugin wanted to include the FCM libraries in it's
> plugin.xml it would do:
> <framework src="com.google.firebase:firebase-messaging:$PlayServicesVersion"/>
> and the cordova-plugin-google-analytics wanted to include Play Services in
> it's plugin.xml it would do:
> {code}
> <framework
> src="com.google.android.gms:play-services-analytics:$PlayServicesVersion" />
> {code}
> they would both use the same version of Play Services. This gets around the
> problem of plugins using + in the framework tag and having two plugins pin
> different versions of Play Services.
> The + wildcard fails to compile with the following error:
> {code}
> > Failed to apply plugin [id 'com.google.gms.google-services']
> > For input string: "+"
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
