[ 
https://issues.apache.org/jira/browse/CB-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147686#comment-16147686
 ] 

ASF GitHub Bot commented on CB-12930:
-------------------------------------

Github user adamhaile commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/207#discussion_r136143196
  
    --- Diff: src/windows/FileProxy.js ---
    @@ -751,7 +751,13 @@ module.exports = {
             if (!fs || !validName(path)){
                 fail(FileError.ENCODING_ERR);
                 return;
    -        }           
    +        }
    +       
    +        //check trailing "/"
    --- End diff --
    
    Correct.  I submitted a (dup) JIRA report that explains why this slash 
causes a failure downstream: https://issues.apache.org/jira/browse/CB-12945 .


> File plugin getDirectory on windows fails on path ending with slash
> -------------------------------------------------------------------
>
>                 Key: CB-12930
>                 URL: https://issues.apache.org/jira/browse/CB-12930
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-file
>            Reporter: Giuseppe La Torre
>            Priority: Minor
>
> On Windows, getDirectory with a path ending with '/' fails.
> On all other platform it works as intended.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to