[
https://issues.apache.org/jira/browse/CB-13273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167972#comment-16167972
]
ASF GitHub Bot commented on CB-13273:
-------------------------------------
GitHub user mhartington opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/85
CB-13273: fix statusbar spacing with new iphoneX
### Platforms affected
iOS
### What does this PR do?
Adds additional check for iOS11/iPhone X and the new statusbar size
### What testing has been done on this change?
Manual testing on devices and simulators.
Note: I messed on the commit message format, tagged the wrong jira issue.
But there is an issue for this.
https://issues.apache.org/jira/browse/CB-13273
### Checklist
- [ x] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mhartington/cordova-plugin-statusbar
CB-12886cordova-plugin-statusbar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-statusbar/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit f4dbcc2d61c01c2766afdc5e40d1c47226a04f5d
Author: mhartington <[email protected]>
Date: 2017-09-15T13:50:42Z
CB-12886: fix statusbar spacing with new iphoneX
----
> Webview is sized incorrectly on iPhone X (Simulator)
> ----------------------------------------------------
>
> Key: CB-13273
> URL: https://issues.apache.org/jira/browse/CB-13273
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Affects Versions: cordova-ios 4.5.0
> Environment: Xcode 9.0 (9A235)
> Simulator 10.0 (SimulatorApp-829.6) - iPhone X
> Reporter: Dave Alden
> Assignee: Shazron Abdullah
> Labels: iPhoneX, ios11
> Attachments: fig1.png, fig2.png, Simulator Screen Shot - iPhone X -
> 2017-09-14 at 15.52.54.png, Simulator Screen Shot - iPhone X - 2017-09-15 at
> 09.20.48.png, webview-test.zip
>
>
> New app with [email protected] (using default UIWebView) running on iPhone X
> Simulator does not size correctly, leaving black areas above and below the
> app content and white bars between the black areas and app content.
> Adding cordova-plugin-wkwebview-engine so Cordova uses WKWebView, white bars
> go away, but the black areas remain:
> !https://cdn.pbrd.co/images/GKeaEPg.png|height=640!
> !https://cdn.pbrd.co/images/GKeaWwK.png|height=640!
> Setting
> {code:html}viewport-fit=cover{code}
> fixes the white bar issue with UIWebView, as outlined here
> [http://stephenradford.me/removing-the-white-bars-in-safari-on-iphone-x/],
> but the black areas remain:
> [^Simulator Screen Shot - iPhone X - 2017-09-14 at 15.52.54.png]
> Attached Cordova project illustrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
