[ 
https://issues.apache.org/jira/browse/CB-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175543#comment-16175543
 ] 

ASF GitHub Bot commented on CB-5758:
------------------------------------

GitHub user brad opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/243

    CB-5758: (android/ios) support trusting self-signed certificates

    
    ### Platforms affected
    
    Android,iOS
    
    ### What does this PR do?
    
    Gives the ability to trust self-signed certificates
    
    ### What testing has been done on this change?
    
    Used in a production app for 2 years
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/orcasgit/cordova-plugin-inappbrowser trust-ca

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #243
    
----
commit 3f3f70d7f15dd1b27f958784b17878bcfe19f8ce
Author: Brad Pitcher <[email protected]>
Date:   2015-07-10T22:25:20Z

    give the ability to trust a certificate authority

commit 3b0e6be630daef42bd0ba59e56af2cd70b4e560a
Author: Brad Pitcher <[email protected]>
Date:   2016-08-15T16:03:20Z

    enable adding trusted CA in iOS

commit 5aebef06bb2e3dc8a9d5cbf13f37f289e7f16a12
Author: Brad Pitcher <[email protected]>
Date:   2017-09-21T22:08:14Z

    undo unneeded description change

----


> Give same behavior to InAppBrowser as CordovaWebView for self-signed certs
> --------------------------------------------------------------------------
>
>                 Key: CB-5758
>                 URL: https://issues.apache.org/jira/browse/CB-5758
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: cordova-plugin-inappbrowser
>            Reporter: Marcel Kinard
>            Priority: Minor
>
> See CB-3576 for history. This is a request that came from there.
> At least on the Android platform, the main webview (CordovaWebView) will 
> silently accept self-signed certs when debuggable="true" in 
> AndroidManifest.xml. (Hopefully other platforms have a similar behavior in 
> pre-production.) The goal of this new feature is to get InAppBrowser to have 
> the same behavior as the main webview in this respect, which is does not have 
> today. Then both the main webview and InAppBrowser will behave consistently 
> when they encounter https connections that have a self-signed cert.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to