[
https://issues.apache.org/jira/browse/CB-12834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176544#comment-16176544
]
ASF GitHub Bot commented on CB-12834:
-------------------------------------
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/244
CB-12834: (android) Fix bug when opening a download link
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
It adds a dialog to request permissions when a file is downloaded in the
inappbrowser. I have committed the changes using the given format, original
changes are from #201
### What testing has been done on this change?
Multiple Android devices have been tested. Different download links,
cancelling the download then re-downloading.
### Checklist
- [x ] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infil00p/cordova-plugin-inappbrowser
inappbrowser_download
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/244.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #244
----
commit 8f22a150892f51e910fe4d5b14d56c607075abe8
Author: Mèir Noordermeer <[email protected]>
Date: 2017-05-19T09:26:29Z
CB-12834: (android) Fix bug when opening a download link
----
> Opening a link to a file in the inappbrowser on Android crashes the app
> -----------------------------------------------------------------------
>
> Key: CB-12834
> URL: https://issues.apache.org/jira/browse/CB-12834
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
> Environment: Android > 4.4
> Reporter: Mèir Noordermeer
> Priority: Critical
> Labels: android, cordova, download, inappbrowser
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When opening a link to a a file (a PDF, for example) the inappbrowser
> crashes, because on Android versions of 4.4 storage permissions are not
> automatically granted anymore. Thus these should be requested instead of
> letting the app crash.
> I am creating this issue to follow the guidelines of pull requests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
