[
https://issues.apache.org/jira/browse/CB-13294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209640#comment-16209640
]
ASF GitHub Bot commented on CB-13294:
-------------------------------------
GitHub user kelvindart opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/95
CB-13294 Remove cordova-plugin-compat
### Platforms affected
[email protected]
### What does this PR do?
Removes the dependency on cordova-plugin-compat, and includes checks for
min platform version.
### What testing has been done on this change?
Testing 1:
- Add local plugin to project containing [email protected]
- Verify plugin installs, and app runs.
Testing 2:
- Add local plugin to project containing [email protected]
- Verify plugin does not install.
- Console log as follows:
```
Plugin doesn't support this project's cordova-android version.
cordova-android: 6.2.3, failed version requirement: >=6.3.0
Skipping 'cordova-plugin-geolocation' for android
```
This is desirable - this change stops the plugin being installed on
`<[email protected]`
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kelvindart/cordova-plugin-geolocation master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-geolocation/pull/95.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #95
----
commit 203744d69b84e7ddcee2858c87bc31dd395cc17b
Author: Kelvin Dart <[email protected]>
Date: 2017-10-18T15:52:17Z
CB-13294 Remove cordova-plugin-compat and include cordova-android dependency
----
> Plugins Release Sept 17, 2017
> -----------------------------
>
> Key: CB-13294
> URL: https://issues.apache.org/jira/browse/CB-13294
> Project: Apache Cordova
> Issue Type: Task
> Reporter: Steve Gill
> Assignee: Steve Gill
>
> Following steps at
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Releasing console, compat, device-motion and device-orientation.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
