[
https://issues.apache.org/jira/browse/CB-13123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211855#comment-16211855
]
ASF GitHub Bot commented on CB-13123:
-------------------------------------
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/598
CB-13123 : plugin add should use cordovaDependency instead
of plugin.xml engine tag
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
plugin add/ install should use cordovaDependency instead of plugin.xml
engine tag
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-13123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/598.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #598
----
commit 5d6ad4a3dc4ed41b87140fcd9cf83d359b6fb798
Author: Audrey So <[email protected]>
Date: 2017-10-18T20:47:00Z
CB-13123 : plugin add/ install should use cordovaDependency instead of
plugin.xml engine tag
----
> plugin add should use cordovaDependency instead of plugin.xml engine tag
> ------------------------------------------------------------------------
>
> Key: CB-13123
> URL: https://issues.apache.org/jira/browse/CB-13123
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
> Reporter: Steve Gill
> Assignee: Audrey So
> Labels: tools-next
> Fix For: cordova@8
>
>
> We have been planning on switching from plugin.xml engine tag to
> cordovaDependencies element in package.json when it comes to resolving
> project dependencies during plugin add.
> I suggest we update the code to use cordovaDependencies. Maybe we fallback on
> plugin.xml engine element until we do a major cordova release where we drop
> engine element fully.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
