[
https://issues.apache.org/jira/browse/CB-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221902#comment-16221902
]
ASF GitHub Bot commented on CB-13502:
-------------------------------------
GitHub user jh3141 opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/152
CB-13502: (android) Implementation of setRate method for Android
Marshmallow and later
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Support the "setRate" method already supported on iOS for Android
Marshmallow devices (API 23) or later.
### What testing has been done on this change?
Tested manually on two devices running different vendor versions of Android
6.0.
No automated test provided, as I can't see how to restrict the test
environment such that the test only runs on Android versions that support the
feature. I imagine somebody more familiar than myself can easily update
media.spec.24 to reflect the change.
### Checklist
- [X ] [Reported an
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jh3141/cordova-plugin-media master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit e699f62481c780b00bf11ecedfc2f2cd4bf320a0
Author: Jules <ju...@meridiandigital.co.uk>
Date: 2017-10-26T09:10:54Z
Support setRate() on Android Marshmallow and above
commit 93432310bde6a837d5f276a2726bad0a2c9a6b54
Author: Jules <ju...@meridiandigital.co.uk>
Date: 2017-10-27T07:06:33Z
Allow rate changes to be applied before the file is prepared
----
> Android - add support for "setRate" method already available on iOS
> -------------------------------------------------------------------
>
> Key: CB-13502
> URL: https://issues.apache.org/jira/browse/CB-13502
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-media
> Reporter: Julian Hall
> Priority: Minor
>
> The iOS media plugin supports a method "setRate" which changes the playback
> rate. Android has support for this feature in the MediaPlayer class used by
> the media plugin since API version 23 (Marshmallow), therefore supporting
> this method there is very easy.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
