[
https://issues.apache.org/jira/browse/CB-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224860#comment-16224860
]
ASF GitHub Bot commented on CB-11244:
-------------------------------------
macdonst commented on issue #389: CB-11244: Studio Project Compatibility: Now
with merge commit
URL: https://github.com/apache/cordova-android/pull/389#issuecomment-340433367
@infil00p I've run the following commands:
```
cordova create androidTest
cd ./androidTest
cordova platform add
git://github.com/infil00p/cordova-android.git#StudioProjectCompat
cordova plugin add [email protected]
```
which resulted in the following error:
```
Installing "phonegap-plugin-push" for android
Android Studio project detected
Failed to install 'phonegap-plugin-push': Error: Unable to graft xml at
selector "/manifest" from
"/Users/smacdona/code/androidTest/platforms/android/app/src/main/res/xml/config.xml"
during config install
at ConfigFile_graft_child [as graft_child]
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigFile.js:122:19)
at PlatformMunger_apply_file_munge [as apply_file_munge]
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:81:34)
at munge_helper
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:236:14)
at PlatformMunger.add_plugin_changes
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/ConfigChanges/ConfigChanges.js:157:12)
at
/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:123:29
at _fulfilled
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:854:54)
at self.promiseDispatch.done
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:883:30)
at Promise.promise.promiseDispatch
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:816:13)
at
/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:877:14
at runSingle
(/Users/smacdona/code/androidTest/platforms/android/cordova/node_modules/q/q.js:137:13)
Error: Unable to graft xml at selector "/manifest" from
"/Users/smacdona/code/androidTest/platforms/android/app/src/main/res/xml/config.xml"
during config install
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update Android Project Structure to be more compatible with Android Studio
> --------------------------------------------------------------------------
>
> Key: CB-11244
> URL: https://issues.apache.org/jira/browse/CB-11244
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Reporter: Joe Bowser
> Assignee: Joe Bowser
> Priority: Blocker
> Labels: CordovaAndroidSix, android-next
>
> Currently our existing Android projects have the old Android Project
> structure created by default, even for new projects, which makes no sense
> since we no longer support Eclipse as the default project editor and have
> moved to Android Studio for Android development.
> The main reason for doing this is to clean up dependencies and to allow for
> projects and dependencies to work more like how modern Android projects work
> and to remove as much custom Gradle code as possible. This would also allow
> us in the future to move towards having Android Plugin code work as Android
> Libraries with Resources instead of just copying things across, which gives
> us the ability to add JUnit tests and bundled resources. This would
> dramatically increase the quality of plugins such as InAppBrowser, and third
> party plugins such as the Barcode Scanner.
> This would have to be done on the next major version, and the upgrade would
> be tricky to do. However, the benefits at this point would greatly outweigh
> the costs of maintaining the old project structure. The old cordova-common
> code in Cordova-Android 5.0.x would allow for plugins in the short term to
> work with both projects until we get the new project structure ready.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
