[
https://issues.apache.org/jira/browse/CB-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16230465#comment-16230465
]
ASF GitHub Bot commented on CB-13523:
-------------------------------------
codecov-io commented on issue #347: CB-13523: Add flag for Xcode-managed
provisioning (DON'T MERGE)
URL: https://github.com/apache/cordova-ios/pull/347#issuecomment-340945363
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr&el=h1)
Report
> Merging
[#347](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-ios/commit/aaf229b0370ff315b571ea8b7c4648c315fb322d?src=pr&el=desc)
will **increase** coverage by `0.02%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 63.43% 63.45% +0.02%
==========================================
Files 14 14
Lines 1690 1691 +1
Branches 283 284 +1
==========================================
+ Hits 1072 1073 +1
Misses 618 618
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz)
| `36.61% <66.66%> (+0.29%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr&el=footer).
Last update
[aaf229b...333c879](https://codecov.io/gh/apache/cordova-ios/pull/347?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add build config option to enable Xcode automatic provisioning
> --------------------------------------------------------------
>
> Key: CB-13523
> URL: https://issues.apache.org/jira/browse/CB-13523
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
> Environment: Xcode 9
> Cordova-iOS 4.5.3
> Reporter: Darryl Pogue
> Assignee: Darryl Pogue
> Priority: Major
>
> Xcode 9 made more changes to how provisioning works for apps, particularly
> around manual vs automatic signing.
> The changes required to support manual signing of release builds was
> implemented as part of CB-13315.
> In order for automatic signing to work, we need to pass an additional flag to
> xcodebuild to allow Xcode to manage automatically updating provisioning
> profiles as needed. I want to keep this being a build config option because
> many people may not want to grant Xcode such power by default.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
