[
https://issues.apache.org/jira/browse/CB-13485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234915#comment-16234915
]
ASF GitHub Bot commented on CB-13485:
-------------------------------------
akdor1154 closed pull request #601: CB-13485: Test with Node8
URL: https://github.com/apache/cordova-lib/pull/601
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index aec9bd618..54e131f74 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,6 +5,7 @@ git:
node_js:
- "4"
- "6"
+ - "8"
install:
- git clone https://github.com/apache/cordova-js --depth 10
- git clone https://github.com/apache/cordova-fetch --depth 10
diff --git a/appveyor.yml b/appveyor.yml
index 535f54682..83f76fd51 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -5,6 +5,7 @@ environment:
matrix:
- nodejs_version: "4"
- nodejs_version: "6"
+ - nodejs_version: "8"
install:
- ps: Install-Product node $env:nodejs_version
diff --git a/spec/cordova/util.spec.js b/spec/cordova/util.spec.js
index 08b0a16b1..40fcf5df5 100644
--- a/spec/cordova/util.spec.js
+++ b/spec/cordova/util.spec.js
@@ -312,8 +312,9 @@ describe('util module', function () {
describe('getPlatformApiFunction', function () {
it('Test 027 : should throw error informing user to update
platform', function () {
- expect(function () { util.getPlatformApiFunction('some/path',
'android'); }).toThrow(new Error // eslint-disable-line func-call-spacing
- ('Uncaught, unspecified "error" event. ( Using this version of
Cordova with older version of cordova-android is deprecated. Upgrade to
[email protected] or newer.)'));
+ expect(function () { util.getPlatformApiFunction('some/path',
'android'); }).toThrowError(
+ /(Uncaught, unspecified|Unhandled) "error" event. \( Using
this version of Cordova with older version of cordova-android is deprecated\.
Upgrade to cordova-android@5\.0\.0 or newer.\)/
+ );
});
it('Test 028 : should throw error if platform is not supported',
function () {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Not tested against Node 8
> -------------------------
>
> Key: CB-13485
> URL: https://issues.apache.org/jira/browse/CB-13485
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
> Reporter: Jarrad Whitaker
> Priority: Minor
> Labels: test
>
> Tests aren't run against Node 8 in travis.
> This is a slight problem as a couple of them fail for trivial reasons (error
> string matching).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
