[ 
https://issues.apache.org/jira/browse/CB-13532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244644#comment-16244644
 ] 

ASF GitHub Bot commented on CB-13532:
-------------------------------------

dpogue commented on issue #607: :CB-13532 : updated to include a check for 
pkgJson devDependencies
URL: https://github.com/apache/cordova-lib/pull/607#issuecomment-342942707
 
 
   :+1:
   
   Just to confirm the intention: Cordova will prefer versions listed in 
`dependencies` over `devDependencies`? That makes sense to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Cordova fails to find platform/plugin versions in package.json devDependencies
> ------------------------------------------------------------------------------
>
>                 Key: CB-13532
>                 URL: https://issues.apache.org/jira/browse/CB-13532
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>            Reporter: Darryl Pogue
>              Labels: tools-next
>
> Cordova only looks at the {{dependencies}} section of package.json, and 
> ignores anything specified in {{devDependencies}}. This results in the 
> default pinned versions for platforms/plugins being used.
> Code in question: 
> https://github.com/apache/cordova-lib/blob/da8ebf6cb81dd84c22e24fdf0baff9837a544b2d/src/cordova/platform/addHelper.js#L109-L113
> This is wrong because Cordova (and its related bits) is not a dependency of 
> my application code, it is a build tool that belongs in devDependencies.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to