[ 
https://issues.apache.org/jira/browse/CB-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246105#comment-16246105
 ] 

ASF GitHub Bot commented on CB-13396:
-------------------------------------

Lazza commented on issue #135: CB-13396: (ios) Fix image sizing on iPhone X
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/135#issuecomment-334784983
 
 
   Actually, the code of this plugin needs not be changed. However, the 
`cordova-ios` template needs a fix. I am using `cordova-ios@4.5.1` and I've 
added this into `hooks/after_prepare/fix_splash_ios11.sh`:
   
   ```
   #!/bin/bash
   
   if [ ! -d platforms/ios ]; then
       exit 0
   fi
   
   
   NAME="$(find platforms/ios/ -name 'CDVLaunchScreen.storyboard')"
   sed -i '' 's_secondItem="xb3-aO-Qok" 
secondAttribute="top"_secondItem="Ze5-6b-2t3" secondAttribute="bottom"_g' 
"$NAME"
   ```
   
   Basically, there is a wrong constraint in `CDVLaunchScreen.storyboard`. If 
this is fixed, nothing else needs to be changed.
   
   I have created a relevant issue on JIRA: 
https://issues.apache.org/jira/browse/CB-13411

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Splash screen images are resized incorrectly on iPhone X
> --------------------------------------------------------
>
>                 Key: CB-13396
>                 URL: https://issues.apache.org/jira/browse/CB-13396
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-splashscreen
>         Environment: iOS 11 / iPhone X
>            Reporter: Ken Mickles
>              Labels: splashscreen
>
> CDVSplashScreen-updateBounds doesn't take iOS11's new safeAreaInsets into 
> account, causing the image size to change when CDVLaunchScreen.storyboard 
> transitions to the CDVSplashScreen image.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to