[
https://issues.apache.org/jira/browse/CB-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248176#comment-16248176
]
ASF GitHub Bot commented on CB-13562:
-------------------------------------
audreyso opened a new pull request #48: CB-13562 : fixed asset tag when adding
push plugin to browser
URL: https://github.com/apache/cordova-browser/pull/48
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Fixed asset tag when adding push plugin to browser
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [X] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Asset tag creates a directory with same name of targeted file
> -------------------------------------------------------------
>
> Key: CB-13562
> URL: https://issues.apache.org/jira/browse/CB-13562
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser
> Affects Versions: 5.0.1
> Reporter: Simon MacDonald
> Assignee: Jesse MacFadyen
> Labels: reproduced, triaged
>
> Asset tag appears to be broken in the browser platform. According to the docs
> at http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#asset when
> you add an asset tag like:
> {code:xml}
> <asset src="www/foo.js" target="foo.js" />
> {code}
> it should copy www/foo.js to platforms/browser/www/foo.js but instead it
> creates a subdirectory called foo.js and the full path to the file is
> platforms/browser/www/foo.js/foo.js.
> If you want to duplicate this issue please create a new project then:
> cordova platform add [email protected]
> cordova plugin add phonegap-plugin-push
> cordova build browser
> then you will see that
> platforms/browser/www/ServiceWorker.js/ServiceWorker.js exists when it should
> be platforms/browser/www/ServiceWorker.js.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
