[
https://issues.apache.org/jira/browse/CB-13175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256865#comment-16256865
]
ASF GitHub Bot commented on CB-13175:
-------------------------------------
janpio closed pull request #239: CB-13175: fixing windows8.1 crash on startup
URL: https://github.com/apache/cordova-windows/pull/239
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/template/www/cordova.js b/template/www/cordova.js
index 778efd23..b412c0f7 100644
--- a/template/www/cordova.js
+++ b/template/www/cordova.js
@@ -2048,7 +2048,7 @@
// Make title bg color match splashscreen bg color
function colorizeTitleBar () {
var appView =
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
- if (appView.titleBar) {
+ if (isWin10UWP) {
titleInitialBgColor = appView.titleBar.backgroundColor;
appView.titleBar.backgroundColor = titleBgColor;
@@ -2059,7 +2059,7 @@
// Revert title bg color
function revertTitleBarColor () {
var appView =
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
- if (appView.titleBar) {
+ if (isWin10UWP) {
appView.titleBar.backgroundColor = titleInitialBgColor;
appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> 8.1-win crashes on startup
> --------------------------
>
> Key: CB-13175
> URL: https://issues.apache.org/jira/browse/CB-13175
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Affects Versions: Master
> Reporter: Max Kapaln
> Assignee: Jesse MacFadyen
>
> This ticket is a follow up to CB-12784
> The PR submitted with CB-12784 only half fixed the win8 crashing issue. The
> functions colorizeTitleBar() and revertTitleBarColor() exist in
> template/www/cordova.js as well and my PR takes the fix the user applied in
> CB-12784 and adds into cordova.js as well.
> alsorokin original fix (already merged into master):
> https://github.com/apache/cordova-windows/pull/232/commits/279816743f995510a1070a0bf77a3180f11e468a
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
