[ 
https://issues.apache.org/jira/browse/CB-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267330#comment-16267330
 ] 

ASF GitHub Bot commented on CB-12291:
-------------------------------------

infil00p closed pull request #352: CB-12291: (android) Add x86_64, arm64 and 
armeabi architecture flavors
URL: https://github.com/apache/cordova-android/pull/352
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/project/build.gradle 
b/bin/templates/project/build.gradle
index ef2297194..c079c7503 100644
--- a/bin/templates/project/build.gradle
+++ b/bin/templates/project/build.gradle
@@ -181,21 +181,34 @@ android {
 
     if (Boolean.valueOf(cdvBuildMultipleApks)) {
         productFlavors {
+            armeabi {
+                versionCode defaultConfig.versionCode*10 + 1
+                ndk {
+                    abiFilters = ["armeabi"]
+                }
+            }
             armv7 {
                 versionCode defaultConfig.versionCode*10 + 2
                 ndk {
-                    abiFilters "armeabi-v7a", ""
+                    abiFilters = ["armeabi-v7a"]
+                }
+            }
+            arm64 {
+                versionCode defaultConfig.versionCode*10 + 3
+                ndk {
+                    abiFilters = ["arm64-v8a"]
                 }
             }
             x86 {
                 versionCode defaultConfig.versionCode*10 + 4
                 ndk {
-                    abiFilters "x86", ""
+                    abiFilters = ["x86"]
                 }
             }
-            all {
+            x86_64 {
+                versionCode defaultConfig.versionCode*10 + 5
                 ndk {
-                    abiFilters "all", ""
+                    abiFilters = ["x86_64"]
                 }
             }
         }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Cannot create APKs for 64-bit x86 and arm architectures
> -------------------------------------------------------
>
>                 Key: CB-12291
>                 URL: https://issues.apache.org/jira/browse/CB-12291
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-android
>    Affects Versions: Master
>            Reporter: Martin Bektchiev
>            Assignee: Joe Bowser
>              Labels: android-next, build, easyfix
>
> There's no way to produce an APK for x86_64 or arm64 architectures.
> 1. Install https://github.com/couchbaselabs/Couchbase-Lite-PhoneGap-Plugin
> 2. Build for android using `--gradleArg=-PcdvBuildMultipleApks=true 
> --gradleArg=-PcdvBuildArch=x86`
> 3. The resulting APK includes only lib/x86 .so files
> $  unzip -t build/outputs/apk/test-x86-debug.apk
> To enable building APKs for 64-bit architectures cdvBuildArch should support 
> two additional values *x86_64* and *arm64*.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to