[
https://issues.apache.org/jira/browse/CB-13615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271484#comment-16271484
]
ASF GitHub Bot commented on CB-13615:
-------------------------------------
infil00p closed pull request #419: CB-13615: Fix paths to signing properties
files
URL: https://github.com/apache/cordova-android/pull/419
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bin/templates/project/app/build.gradle
b/bin/templates/project/app/build.gradle
index c5f5b2332..32e31f6c8 100644
--- a/bin/templates/project/app/build.gradle
+++ b/bin/templates/project/app/build.gradle
@@ -107,11 +107,11 @@ if (ext.cdvBuildToolsVersion == null) {
ext.cdvBuildToolsVersion = privateHelpers.findLatestInstalledBuildTools()
//ext.cdvBuildToolsVersion = project.ext.defaultBuildToolsVersion
}
-if (ext.cdvDebugSigningPropertiesFile == null &&
file('debug-signing.properties').exists()) {
- ext.cdvDebugSigningPropertiesFile = 'debug-signing.properties'
+if (ext.cdvDebugSigningPropertiesFile == null &&
file('../debug-signing.properties').exists()) {
+ ext.cdvDebugSigningPropertiesFile = '../debug-signing.properties'
}
-if (ext.cdvReleaseSigningPropertiesFile == null &&
file('release-signing.properties').exists()) {
- ext.cdvReleaseSigningPropertiesFile = 'release-signing.properties'
+if (ext.cdvReleaseSigningPropertiesFile == null &&
file('../release-signing.properties').exists()) {
+ ext.cdvReleaseSigningPropertiesFile = '../release-signing.properties'
}
// Cast to appropriate types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Release signing with build.json not working
> -------------------------------------------
>
> Key: CB-13615
> URL: https://issues.apache.org/jira/browse/CB-13615
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
> Reporter: Darryl Pogue
> Assignee: Joe Bowser
> Priority: Blocker
> Labels: android-next
>
> With cordova-android master, I'm not setting signed release builds.
> I'm specifying the keystore and passwords in my build.json file.
> The output of {{cordova build android --device --release}} is as follows:
> {code}
> ANDROID_HOME=/usr/local/Caskroom/android-sdk/25.2.3
> JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home
> Reading build config file: .../build.json
> Reading the keystore from: ../correct.keystore
> studio
> Starting a Gradle Daemon (subsequent builds will be faster)
> :wrapper
> BUILD SUCCESSFUL in 4s
> 1 actionable task: 1 executed
> Subproject Path: CordovaLib
> Subproject Path: app
> Starting a Gradle Daemon (subsequent builds will be faster)
> publishNonDefault is deprecated and has no effect anymore. All variants are
> now published.
> Download
> https://repo1.maven.org/maven2/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar
> The Task.leftShift(Closure) method has been deprecated and is scheduled to be
> removed in Gradle 5.0. Please use Task.doLast(Action) instead.
> at
> build_mwups4l6vzpjxql6irnsfnd4.run(.../platforms/android/app/build.gradle:143)
> :CordovaLib:preBuild UP-TO-DATE
> :CordovaLib:preReleaseBuild UP-TO-DATE
> :CordovaLib:compileReleaseAidl
> :CordovaLib:compileReleaseRenderscript
> :CordovaLib:checkReleaseManifest
> :CordovaLib:generateReleaseBuildConfig
> :CordovaLib:prepareLintJar
> :CordovaLib:generateReleaseResValues
> :CordovaLib:generateReleaseResources
> :CordovaLib:packageReleaseResources
> :CordovaLib:platformAttrExtractor
> :CordovaLib:processReleaseManifest
> :CordovaLib:javaPreCompileRelease
> :CordovaLib:processReleaseJavaRes NO-SOURCE
> :app:preBuild UP-TO-DATE
> :app:preReleaseBuild
> :app:compileReleaseAidl
> :CordovaLib:packageReleaseRenderscript NO-SOURCE
> :app:compileReleaseRenderscript
> :app:checkReleaseManifest
> :app:generateReleaseBuildConfig
> :app:prepareLintJar
> :app:generateReleaseResValues
> :app:generateReleaseResources
> :app:mergeReleaseResources
> :app:createReleaseCompatibleScreenManifests
> :app:processReleaseManifest
> :app:splitsDiscoveryTaskRelease
> :app:compileReleaseNdk NO-SOURCE
> :CordovaLib:mergeReleaseShaders
> :CordovaLib:compileReleaseShaders
> :CordovaLib:generateReleaseAssets
> :CordovaLib:mergeReleaseAssets
> :app:mergeReleaseShaders
> :app:compileReleaseShaders
> :app:generateReleaseAssets
> :app:mergeReleaseAssets
> :app:extractTryWithResourcesSupportJarRelease
> :CordovaLib:compileReleaseNdk NO-SOURCE
> :CordovaLib:mergeReleaseJniLibFolders
> :CordovaLib:transformNativeLibsWithMergeJniLibsForRelease
> :CordovaLib:transformNativeLibsWithIntermediateJniLibsForRelease
> :app:mergeReleaseJniLibFolders
> :app:processReleaseJavaRes NO-SOURCE
> :CordovaLib:processReleaseResources
> :CordovaLib:generateReleaseSources
> :CordovaLib:compileReleaseJavaWithJavacNote: Some input files use or override
> a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> :CordovaLib:transformClassesAndResourcesWithPrepareIntermediateJarsForRelease
> :app:processReleaseResources
> :app:generateReleaseSources
> :app:javaPreCompileRelease
> :app:compileReleaseJavaWithJavac
> :app:compileReleaseSources
> :app:transformClassesWithStackFramesFixerForRelease
> :app:transformClassesWithDesugarForRelease
> :app:transformClassesWithPreDexForRelease
> :app:transformDexWithDexForRelease
> :app:transformNativeLibsWithMergeJniLibsForRelease
> :app:transformResourcesWithMergeJavaResForRelease
> :app:packageRelease
> :app:lintVitalRelease
> :app:assembleRelease
> :app:cdvBuildRelease
> BUILD SUCCESSFUL in 34s
> 46 actionable tasks: 46 executed
> Built the following apk(s):
>
> .../platforms/android/app/build/outputs/apk/release/android-release-unsigned.apk
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
