[
https://issues.apache.org/jira/browse/CB-13614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273084#comment-16273084
]
ASF GitHub Bot commented on CB-13614:
-------------------------------------
geocolumbus opened a new pull request #49: CB-13614: (browser) Fix asset copy
bug.
URL: https://github.com/apache/cordova-browser/pull/49
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
browser
### What does this PR do?
Fixes a bug that prevented assets from the plugin file from copying over
correctly if the asset contained a path.
### What testing has been done on this change?
I tested the cordova-browser with this patch against my own build and
verified that the assets copied correctly, both at the root level and with a
path.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Asset tag create only works if file is targeted to root directory
> -----------------------------------------------------------------
>
> Key: CB-13614
> URL: https://issues.apache.org/jira/browse/CB-13614
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser
> Affects Versions: 5.0.1
> Reporter: George Campbell
> Assignee: Jesse MacFadyen
>
> Inside a plugin.xml file,
> <asset src="www/style/inappbrowser.css" target="style/inappbrowser.css"/>
> results in:
> cp: copyFileSync: could not write to dest file
> (code=ENOENT):/Users/campbelg/IdeaProjects/wms-circ-app/platforms/browser/platform_www/style/inappbrowser.css
> Related to CB-13562, which fixed the case of an asset file whose target was
> the root directory. This bug is for assets whose target contains a directory.
> The expected behavior is described by the plugin.xml documentation:
> https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#asset
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
