[ 
https://issues.apache.org/jira/browse/CB-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282827#comment-16282827
 ] 

ASF GitHub Bot commented on CB-13641:
-------------------------------------

IndieSW opened a new pull request #245: CB-13641: (windows) support transparent 
splash screen background color.
URL: https://github.com/apache/cordova-windows/pull/245
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
   is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   windows
   
   ### What does this PR do?
   adds support for transparent splash screen background color.
   
   ### What testing has been done on this change?
   built app with forked/updated repository and manually tested splash screen 
background color with RGB and 'transparent' values.
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
   - [x] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Splash screen on Windows does not allow for transparent background color.
> -------------------------------------------------------------------------
>
>                 Key: CB-13641
>                 URL: https://issues.apache.org/jira/browse/CB-13641
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-windows
>    Affects Versions: [email protected]
>         Environment: Windows 10.
>            Reporter: Terence Bandoian
>            Priority: Trivial
>              Labels: newbie
>             Fix For: Master
>
>
> The splash screen background color defaults to #464646.  In splashscreen.js, 
> the background color is expected to be a hex value and values longer than 
> seven characters are spliced to remove the alpha channel.  The configured 
> value could be checked for the value 'transparent' and, in that case, not 
> spliced.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to