[
https://issues.apache.org/jira/browse/CB-13057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286789#comment-16286789
]
ASF GitHub Bot commented on CB-13057:
-------------------------------------
stevengill commented on a change in pull request #586: CB-13057 : Remove
cordova platform save command
URL: https://github.com/apache/cordova-lib/pull/586#discussion_r156235507
##########
File path: integration-tests/pkgJson-restore.spec.js
##########
@@ -142,8 +142,8 @@ describe('tests platform/spec restore with --save',
function () {
var cwd = process.cwd();
var pkgJsonPath = path.join(cwd, 'package.json');
var pkgJson;
- var platformsFolderPath = path.join(cwd, 'platforms/platforms.json');
- var platformsJson;
+ //var platformsFolderPath = path.join(cwd, 'platforms/platforms.json');
Review comment:
delete all the stuff that you commented in this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove cordova platform save command
> ------------------------------------
>
> Key: CB-13057
> URL: https://issues.apache.org/jira/browse/CB-13057
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
> Affects Versions: cordova@8
> Reporter: Steve Gill
> Assignee: Audrey So
> Labels: backlog, tools-next
> Fix For: cordova@8
>
>
> With autosaving now in place, we don't need `cordova platform save` anymore.
> By removing this command, we can also remove
> cordovaProject/platforms/platforms.json &
> cordova-lib/src/cordova/platform_metadata.js
> Deprecation notice will be added to cordova platform save until save command
> is removed in cordova@8
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
