[
https://issues.apache.org/jira/browse/CB-13662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288212#comment-16288212
]
ASF GitHub Bot commented on CB-13662:
-------------------------------------
macdonst commented on a change in pull request #253: CB-13662: remove
deprecated platforms
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/253#discussion_r156483934
##########
File path: plugin.xml
##########
@@ -147,52 +101,6 @@
<source-file src="src/osx/CDVInAppBrowser.m" />
</platform>
- <!-- wp7 -->
- <platform name="wp7">
- <config-file target="Properties/WMAppManifest.xml"
parent="/Deployment/App/Capabilities">
- <Capability Name="ID_CAP_NETWORKING"/>
- </config-file>
-
- <js-module src="www/inappbrowser.js" name="inappbrowser">
- <clobbers target="cordova.InAppBrowser.open" />
- <clobbers target="window.open" />
- </js-module>
- <config-file target="config.xml" parent="/*">
- <feature name="InAppBrowser">
- <param name="wp-package" value="InAppBrowser"/>
- </feature>
- </config-file>
-
- <config-file target="Properties/WMAppManifest.xml"
parent="/Deployment/App/Capabilities">
- <Capability Name="ID_CAP_NETWORKING" />
- </config-file>
-
- <source-file src="src/wp/InAppBrowser.cs" />
- </platform>
-
- <!-- wp8 -->
- <platform name="wp8">
- <config-file target="Properties/WMAppManifest.xml"
parent="/Deployment/App/Capabilities">
- <Capability Name="ID_CAP_NETWORKING"/>
- </config-file>
-
- <js-module src="www/inappbrowser.js" name="inappbrowser">
- <clobbers target="cordova.InAppBrowser.open" />
- <clobbers target="window.open" />
- </js-module>
- <config-file target="config.xml" parent="/*">
- <feature name="InAppBrowser">
- <param name="wp-package" value="InAppBrowser"/>
- </feature>
- </config-file>
-
- <config-file target="Properties/WMAppManifest.xml"
parent="/Deployment/App/Capabilities">
- <Capability Name="ID_CAP_NETWORKING" />
- </config-file>
-
- <source-file src="src/wp/InAppBrowser.cs" />
- </platform>
-
<!-- windows8 -->
Review comment:
@surajpindoria I think you want to get rid of this platform too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove deprecated platforms from inappbrowser plugin
> ----------------------------------------------------
>
> Key: CB-13662
> URL: https://issues.apache.org/jira/browse/CB-13662
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
> Reporter: Suraj Pindoria
> Assignee: Suraj Pindoria
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
