[
https://issues.apache.org/jira/browse/CB-13056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288303#comment-16288303
]
ASF GitHub Bot commented on CB-13056:
-------------------------------------
stevengill commented on a change in pull request #588: CB-13056 : Removed
parsers & platformApi polyfill for webos, blackberry, & ubuntu
URL: https://github.com/apache/cordova-lib/pull/588#discussion_r156500818
##########
File path: src/cordova/util.js
##########
@@ -503,16 +503,5 @@ function getPlatformApiFunction (libDir, platform) {
}
}
- if (!PlatformApi) {
- // The platform just does not expose Api and we will try to polyfill it
- var polyPlatforms = ['blackberry10', 'browser', 'ubuntu', 'webos'];
- if (polyPlatforms.indexOf(platform) > -1) {
- events.emit('verbose', 'Failed to require PlatformApi instance for
platform "' + platform +
- '". Using polyfill instead.');
- PlatformApi = require('../platforms/PlatformApiPoly.js');
- } else {
- throw new Error('Your ' + platform + ' platform does not have
Api.js');
Review comment:
Actually we might want to keep the `throw new Error` part.
Something like
```
if (!PlatformApi) {
throw new Error('Your ' + platform + ' platform does not have Api.js');
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove non platform-API platforms
> ---------------------------------
>
> Key: CB-13056
> URL: https://issues.apache.org/jira/browse/CB-13056
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
> Reporter: Steve Gill
> Assignee: Audrey So
> Labels: tools-next
> Fix For: cordova-8
>
>
> In the next major version of cordova, we should drop all platforms that
> haven't updated to platformAPI
> This includes older browser platforms, webos, blackberry and ubuntu
> We can remove the parsers for these files + the platformAPI polyfill and any
> other files that these platforms use
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
