[
https://issues.apache.org/jira/browse/CB-13666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288445#comment-16288445
]
ASF GitHub Bot commented on CB-13666:
-------------------------------------
macdonst commented on a change in pull request #62: CB-13666 : Removed
deprecated platforms
URL:
https://github.com/apache/cordova-plugin-vibration/pull/62#discussion_r156523617
##########
File path: plugin.xml
##########
@@ -30,102 +30,13 @@
<repo>https://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration.git</repo>
<issue>https://issues.apache.org/jira/browse/CB/component/12320639</issue>
- <!-- firefoxos -->
- <platform name="firefoxos">
- <config-file target="www/config.xml" parent="/*">
- <feature name="Vibration">
- <param name="firefoxos-package" value="Vibration" />
- </feature>
- </config-file>
- <js-module src="src/firefoxos/VibrationProxy.js" name="VibrationProxy">
- <runs />
- </js-module>
- <js-module src="www/vibration.js" name="notification">
- <merges target="navigator.notification" />
- <merges target="navigator" />
- </js-module>
- </platform>
-
- <!-- wp7 -->
- <platform name="wp7">
- <config-file target="config.xml" parent="/*">
- <feature name="Vibration">
- <param name="wp-package" value="Vibration"/>
- </feature>
- </config-file>
- <js-module src="www/vibration.js" name="notification">
- <merges target="navigator.notification" />
- <merges target="navigator" />
- </js-module>
-
- <source-file src="src/wp/Vibration.cs" />
- </platform>
-
- <!-- wp8 -->
- <platform name="wp8">
- <config-file target="config.xml" parent="/*">
- <feature name="Vibration">
- <param name="wp-package" value="Vibration"/>
- </feature>
- </config-file>
- <js-module src="www/vibration.js" name="notification">
- <merges target="navigator.notification" />
- <merges target="navigator" />
- </js-module>
-
- <source-file src="src/wp/Vibration.cs" />
- </platform>
-
- <!-- windows -->
- <platform name="windows">
Review comment:
I don't think you need to remove this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove deprecated platforms for vibration plugin
> ------------------------------------------------
>
> Key: CB-13666
> URL: https://issues.apache.org/jira/browse/CB-13666
> Project: Apache Cordova
> Issue Type: Task
> Reporter: Vishal Mishra
> Assignee: Vishal Mishra
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
