[
https://issues.apache.org/jira/browse/CB-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290450#comment-16290450
]
ASF GitHub Bot commented on CB-13677:
-------------------------------------
maverickmishra closed pull request #143: CB-13677: Remove deprecated platforms
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/143
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/README.md b/README.md
index 86df3193..49ff0ef4 100644
--- a/README.md
+++ b/README.md
@@ -41,11 +41,8 @@ Report issues with this plugin on the [Apache Cordova issue
tracker][Apache Cord
## Supported Platforms
-- Amazon Fire OS
- Android
-- BlackBerry 10
- iOS
-- Windows Phone 7 and 8
- Windows (`cordova-windows` version >= 4.4.0 is required)
- Browser
@@ -353,12 +350,6 @@ projectRoot
<splash src="res/screen/windows/splashscreenphone.png" width="1152"
height="1920"/>
</platform>-->
-<platform name="blackberry10">
- <!-- Add a rim:splash element for each resolution and locale you wish -->
- <!--
http://developer.blackberry.com/html5/documentation/rim_splash_element.html -->
- <rim:splash src="res/screen/blackberry/splashscreen.png"/>
-</platform>
-
<preference name="SplashScreenDelay" value="10000" />
```
@@ -499,7 +490,7 @@ navigator.splashscreen.hide();
```
-### BlackBerry 10, WP8, iOS Quirk
+### iOS Quirk
The `config.xml` file's `AutoHideSplashScreen` setting must be
`false`. To delay hiding the splash screen for two seconds, add a
diff --git a/package.json b/package.json
index 015aec5a..9309f86a 100644
--- a/package.json
+++ b/package.json
@@ -1,20 +1,16 @@
{
"name": "cordova-plugin-splashscreen",
- "version": "4.1.1-dev",
+ "version": "5.0.0-dev",
"description": "Cordova Splashscreen Plugin",
"types": "./types/index.d.ts",
"cordova": {
"id": "cordova-plugin-splashscreen",
"platforms": [
"android",
- "amazon-fireos",
"ubuntu",
"ios",
- "blackberry10",
- "wp8",
- "windows8",
"windows",
- "tizen"
+ "browser"
]
},
"repository": {
@@ -29,14 +25,8 @@
"splashscreen",
"ecosystem:cordova",
"cordova-android",
- "cordova-amazon-fireos",
- "cordova-ubuntu",
"cordova-ios",
- "cordova-blackberry10",
- "cordova-wp8",
- "cordova-windows8",
- "cordova-windows",
- "cordova-tizen"
+ "cordova-windows"
],
"scripts": {
"test": "npm run jshint",
diff --git a/plugin.xml b/plugin.xml
index dc1f3ab5..fb0fc0a6 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -20,7 +20,7 @@
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0";
id="cordova-plugin-splashscreen"
- version="4.1.1-dev">
+ version="5.0.0-dev">
<name>Splashscreen</name>
<description>Cordova Splashscreen Plugin</description>
<license>Apache 2.0</license>
@@ -49,23 +49,6 @@
<source-file src="src/android/SplashScreen.java"
target-dir="src/org/apache/cordova/splashscreen" />
</platform>
- <!-- amazon-fireos -->
- <platform name="amazon-fireos">
- <config-file target="res/xml/config.xml" parent="/*">
- <feature name="SplashScreen">
- <param name="android-package"
value="org.apache.cordova.splashscreen.SplashScreen"/>
- </feature>
- </config-file>
-
- <source-file src="src/android/SplashScreen.java"
target-dir="src/org/apache/cordova/splashscreen" />
- </platform>
-
- <!-- ubuntu -->
- <platform name="ubuntu">
- <header-file src="src/ubuntu/splashscreen.h" />
- <source-file src="src/ubuntu/splashscreen.cpp" />
- </platform>
-
<!-- ios -->
<platform name="ios">
<config-file target="config.xml" parent="/*">
@@ -83,35 +66,6 @@
<framework src="CoreGraphics.framework" />
</platform>
- <!-- blackberry10 -->
- <platform name="blackberry10">
- <source-file src="src/blackberry10/index.js" target-dir="SplashScreen"
/>
- <config-file target="www/config.xml" parent="/widget">
- <feature name="SplashScreen" value="SplashScreen"/>
- </config-file>
- </platform>
-
- <!-- wp8 -->
- <platform name="wp8">
- <config-file target="config.xml" parent="/*">
- <feature name="SplashScreen">
- <param name="wp-package" value="SplashScreen"/>
- <param name="onload" value="true"/>
- </feature>
- </config-file>
-
- <source-file src="src/wp/SplashScreen.cs" />
- <source-file src="src/wp/ResolutionHelper.cs" />
-
- </platform>
-
- <!-- windows8 -->
- <platform name="windows8">
- <js-module src="www/windows/SplashScreenProxy.js"
name="SplashScreenProxy">
- <runs />
- </js-module>
- </platform>
-
<!-- windows -->
<platform name="windows">
<js-module src="www/windows/SplashScreenProxy.js"
name="SplashScreenProxy">
@@ -119,13 +73,6 @@
</js-module>
</platform>
- <!-- tizen -->
- <platform name="tizen">
- <js-module src="src/tizen/SplashScreenProxy.js"
name="SplashScreenProxy">
- <runs />
- </js-module>
- </platform>
-
<!-- browser -->
<platform name="browser">
<js-module src="src/browser/SplashScreenProxy.js"
name="SplashScreenProxy">
diff --git a/src/blackberry10/index.js b/src/blackberry10/index.js
deleted file mode 100644
index c6825064..00000000
--- a/src/blackberry10/index.js
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright 2013 Research In Motion Limited.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-/* global PluginResult */
-
-module.exports = {
- show: function (success, fail, args, env) {
- var result = new PluginResult(args, env);
- result.error("Not supported on platform", false);
- },
-
- hide: function (success, fail, args, env) {
- var result = new PluginResult(args, env);
- window.qnx.webplatform.getApplication().windowVisible = true;
- result.ok(undefined, false);
- }
-};
diff --git a/src/tizen/SplashScreenProxy.js b/src/tizen/SplashScreenProxy.js
deleted file mode 100644
index 06c06972..00000000
--- a/src/tizen/SplashScreenProxy.js
+++ /dev/null
@@ -1,43 +0,0 @@
-/*
- *
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
-*/
-
-( function() {
-
-var win = null;
-
-module.exports = {
- show: function() {
- if ( win === null ) {
- win = window.open('splashscreen.html');
- }
- },
-
- hide: function() {
- if ( win !== null ) {
- win.close();
- win = null;
- }
- }
-};
-
-require("cordova/tizen/commandProxy").add("SplashScreen", module.exports);
-
-})();
diff --git a/src/ubuntu/splashscreen.cpp b/src/ubuntu/splashscreen.cpp
deleted file mode 100644
index 1c9ecac8..00000000
--- a/src/ubuntu/splashscreen.cpp
+++ /dev/null
@@ -1,42 +0,0 @@
-/*
- *
- * Copyright 2013 Canonical Ltd.
- *
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
-*/
-
-#include <QQuickItem>
-
-#include "splashscreen.h"
-#include <cordova.h>
-
-#define SPLASHSCREEN_STATE_NAME "splashscreen"
-
-Splashscreen::Splashscreen(Cordova *cordova): CPlugin(cordova) {
-}
-
-void Splashscreen::show(int, int) {
- m_cordova->rootObject()->setProperty("splashscreenPath",
m_cordova->getSplashscreenPath());
-
- m_cordova->pushViewState(SPLASHSCREEN_STATE_NAME);
-}
-
-void Splashscreen::hide(int, int) {
- m_cordova->popViewState(SPLASHSCREEN_STATE_NAME);
-}
diff --git a/src/ubuntu/splashscreen.h b/src/ubuntu/splashscreen.h
deleted file mode 100644
index 1d437f84..00000000
--- a/src/ubuntu/splashscreen.h
+++ /dev/null
@@ -1,52 +0,0 @@
-/*
- *
- * Copyright 2013 Canonical Ltd.
- *
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
-*/
-
-#ifndef SPLASHSCREEN_H
-#define SPLASHSCREEN_H
-
-#include <QtCore>
-#include <cplugin.h>
-
-class Splashscreen: public CPlugin {
- Q_OBJECT
-public:
- explicit Splashscreen(Cordova *cordova);
-
- virtual const QString fullName() override {
- return Splashscreen::fullID();
- }
-
- virtual const QString shortName() override {
- return "SplashScreen";
- }
-
- static const QString fullID() {
- return "SplashScreen";
- }
-
-public slots:
- void show(int, int);
- void hide(int, int);
-};
-
-#endif // SPLASHSCREEN_H
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove deprecated platforms for splash screen plugin
> ----------------------------------------------------
>
> Key: CB-13677
> URL: https://issues.apache.org/jira/browse/CB-13677
> Project: Apache Cordova
> Issue Type: Task
> Reporter: Vishal Mishra
> Assignee: Vishal Mishra
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
