[
https://issues.apache.org/jira/browse/CB-12218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307659#comment-16307659
]
ASF GitHub Bot commented on CB-12218:
-------------------------------------
deton opened a new pull request #425: CB-12218: (android) Fix consistency of
null result message
URL: https://github.com/apache/cordova-android/pull/425
### Platforms affected
Android
### What does this PR do?
Fix problem that JavaScript receives ""(empty string) instead of null
if plugin sends null result from new thread.
### What testing has been done on this change?
npm test
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> inconsistent null handling between EVAL and ONLINE bridge modes
> ---------------------------------------------------------------
>
> Key: CB-12218
> URL: https://issues.apache.org/jira/browse/CB-12218
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
> Affects Versions: 6.0.0
> Environment: Android
> Reporter: Alan Kinzie
> Assignee: Joe Bowser
> Attachments: CB12218.zip
>
>
> If the Android native code invokes the success callback like this:
> callbackContext.success(null);
> then the value given to the javascript callback changes depending on the
> bridge type used.
> If the ONLINE_EVENT type is used, then null will be passed to the javascript
> callback.
> ie: if result is the parameter of the javascript success callback then
> result === null // will be true
> result === "" // will be false
> If the EVAL_BRIDGE type is used, then an empty string will be passed to the
> javascript callback.
> ie: if result is the parameter of the javascript success callback then
> result === null // will be false
> result === "" // will be true
> The value of the parameter given to the success callback should not change
> depending on the bridge type. Since ONLINE_EVENT was the default before
> cordova android 6.0.0, I am inclined to think the ONLINE bridge is doing the
> correct behaviour. Also, converting null to an empty string loses
> information. Therefore I think the EVAL mode should to be changed to be
> consistent with the ONLINE mode.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
