[
https://issues.apache.org/jira/browse/CB-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319675#comment-16319675
]
ASF GitHub Bot commented on CB-12940:
-------------------------------------
codecov-io commented on issue #335: CB-12940: [IOS] Use deployment-target from
config.xml for platform version in Podfile
URL: https://github.com/apache/cordova-ios/pull/335#issuecomment-326194804
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/335?src=pr&el=h1)
Report
> Merging
[#335](https://codecov.io/gh/apache/cordova-ios/pull/335?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-ios/commit/4f873f7b931f080b0ed2edd31502571ae93b334d?src=pr&el=desc)
will **increase** coverage by `0.47%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/335?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 63.45% 63.93% +0.47%
==========================================
Files 14 14
Lines 1691 1694 +3
Branches 284 285 +1
==========================================
+ Hits 1073 1083 +10
+ Misses 618 611 -7
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-ios/pull/335?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/335/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz)
| `58.97% <100%> (+5.07%)` | :arrow_up: |
|
[bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/335/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=)
| `77.59% <100%> (+0.18%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/335?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/335?src=pr&el=footer).
Last update
[4f873f7...96d5546](https://codecov.io/gh/apache/cordova-ios/pull/335?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use deployment-target for platform version in Podfile
> -----------------------------------------------------
>
> Key: CB-12940
> URL: https://issues.apache.org/jira/browse/CB-12940
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
> Affects Versions: [email protected]
> Reporter: Todd Miller
> Assignee: Shazron Abdullah
> Labels: backlog
> Fix For: [email protected]
>
>
> The current Podfile.js script is hardcoded to set the platform ios version to
> 8.0. However, there are some pods that require 9.0 or they will fail to
> install. The deployment-target preference should be honored and used when
> generating the Podfile.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
