[ 
https://issues.apache.org/jira/browse/CB-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321596#comment-16321596
 ] 

ASF GitHub Bot commented on CB-13772:
-------------------------------------

darcymeyer opened a new pull request #291: CB-13772: print version numbers 
correctly in "cordova requirements"
URL: https://github.com/apache/cordova-cli/pull/291
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
   is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### What does this PR do?
   This PR fixes the bug where `cordova requirements` did not print out version 
numbers correctly.
   Previously, it would print something like `ios-deploy: installed [object 
Object]`. Now it prints `ios-deploy: installed 1.9.2`.
   
   ### What testing has been done on this change?
   This was a one line fix so none of the automated testing was run. I manually 
verified that the fix prints the version numbers correctly for the Android and 
iOS requirements.
   
   ### Checklist
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   Issue reported here: https://issues.apache.org/jira/browse/CB-13772
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
   - [X] Added automated test coverage as appropriate for this change.
   (No additional testing applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> CLI `cordova requirements` printing out [object Object] in place of some 
> version numbers
> ----------------------------------------------------------------------------------------
>
>                 Key: CB-13772
>                 URL: https://issues.apache.org/jira/browse/CB-13772
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-cli
>    Affects Versions: [email protected]
>         Environment: macOS High Sierra 10.13.2
> npm v5.6.0
> node v9.4.0
> cordova CLI v8.0.0
>            Reporter: Darcy Meyer
>            Priority: Minor
>
>  When `cordova requirements` is executed, the output prints [object Object] 
> in place of some of the version numbers.
> e.g.
> {code}
> $ cordova requirements
> Android Studio project detected
> Requirements check results for android:
> Java JDK: installed 1.8.0
> Android SDK: installed true
> Android target: not installed 
> avdmanager: Command failed with exit code 1
> Gradle: not installed 
> Could not find an installed version of Gradle either in Android Studio,
> or on your system to install the gradle wrapper. Please include gradle 
> in your path, or install Android Studio
> Requirements check results for ios:
> Apple macOS: installed darwin
> Xcode: installed [object Object]
> ios-deploy: installed [object Object]
> CocoaPods: installed [object Object]
> {code}
> Here, the versions of the ios requirements are not displayed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to