[
https://issues.apache.org/jira/browse/CB-13803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Brody closed CB-13803.
----------------------------
Resolution: Invalid
Closing as invalid since it does not really crash with any uncaught exception
on Windows 8.1. I I would add log statements to cordova.js from the latest
version of cordova-windows:
{code}
@@ -2034,7 +2034,9 @@
// Enter fullscreen mode
function enterFullScreen () {
+ console.log('enterFullScreen');
if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else
crash on 8.1
+ console.log('get application view');
var view =
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useCoreWindow);
view.suppressSystemOverlays = true;
@@ -2043,7 +2045,9 @@
// Exit fullscreen mode
function exitFullScreen () {
+ console.log('exitFullScreen');
if (Windows.UI.ViewManagement.ApplicationViewBoundsMode) { // else
crash on 8.1
+ console.log('get application view');
var view =
Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
view.setDesiredBoundsMode(Windows.UI.ViewManagement.ApplicationViewBoundsMode.useVisible);
view.suppressSystemOverlays = false;
@@ -2072,6 +2076,7 @@
// Displays the extended splash screen. Pass the splash screen object
retrieved during activation.
function show () {
+ console.log('spashscreen show');
enterFullScreen();
colorizeTitleBar();
disableUserInteraction();
{code}
and then run on Windows 8.1 I get the following in the JavaScript Console
(redacted with extra warning messages removed):
{code}
spashscreen show
enterFullScreen
get application view
Received Event: deviceready
exitFullScreen
get application view
{code}
So {{if (Windows.UI.ViewManagement.ApplicationViewBoundsMode)}} proves itself
to work as a guard to avoid possible crash on Windows 8.1.
Remaining task is to remove the incorrrect "else crash on 8.1" comments, will
add this to the code cleanup in CB-13802.
> Possible crash on Windows 8.1 in case of fullscreen mode
> --------------------------------------------------------
>
> Key: CB-13803
> URL: https://issues.apache.org/jira/browse/CB-13803
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: Chris Brody
> Assignee: Jesse MacFadyen
> Priority: Major
>
> From CB-13802 I noticed a couple spots in splashscreen.js, related to
> fullscreen mode, marked "else crash on 8.1". The changes I recommended in
> CB-13802 should resolve this issue.
> I would be happy if CB-13802 would be resolved, with this one marked as a
> duplicate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
