[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337285#comment-16337285
 ] 

ASF GitHub Bot commented on CB-13392:
-------------------------------------

purplecabbage commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163496852
 
 

 ##########
 File path: src/ios/CDVSplashScreen.m
 ##########
 @@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath 
ofObject:(id)object change:(NS
     [self updateImage];
 }
 
+- (UIColor *)colorFromHexString:(NSString *)hexString {
 
 Review comment:
   Statusbar handles all of this in js here: 
https://github.com/apache/cordova-plugin-statusbar/blob/master/www/statusbar.js#L75
   including shortcut css, like #345 => #334455

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> -----------------------------------
>
>                 Key: CB-13392
>                 URL: https://issues.apache.org/jira/browse/CB-13392
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-splashscreen
>    Affects Versions: Master
>         Environment: Available on Android and iOS.
>            Reporter: Jonathan Corral
>            Priority: Minor
>              Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to