[ 
https://issues.apache.org/jira/browse/CB-13831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339626#comment-16339626
 ] 

ASF GitHub Bot commented on CB-13831:
-------------------------------------

codecov-io commented on issue #430: CB-13831: (android) Update 
`android-versions` to 1.3.0 to support SDK 27.
URL: https://github.com/apache/cordova-android/pull/430#issuecomment-360560935
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/430?src=pr&el=h1) 
Report
   > Merging 
[#430](https://codecov.io/gh/apache/cordova-android/pull/430?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/cc08e9d84a3f7cf76a623006c6a7e48814d74cec?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/430/graphs/tree.svg?token=q14nMf6C5a&src=pr&width=650&height=150)](https://codecov.io/gh/apache/cordova-android/pull/430?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #430   +/-   ##
   =======================================
     Coverage   43.95%   43.95%           
   =======================================
     Files          17       17           
     Lines        1711     1711           
     Branches      318      318           
   =======================================
     Hits          752      752           
     Misses        959      959
   ```
   
   
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/430?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/430?src=pr&el=footer).
 Last update 
[cc08e9d...f91102e](https://codecov.io/gh/apache/cordova-android/pull/430?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Update `android-versions` npm dependency to support Android API 27.
> -------------------------------------------------------------------
>
>                 Key: CB-13831
>                 URL: https://issues.apache.org/jira/browse/CB-13831
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: cordova-android
>            Reporter: Jesse Rosenberger
>            Assignee: Joe Bowser
>            Priority: Trivial
>
> The current version of {{cordova-android}} currently bundles (via 
> {{package.json}}'s {{bundledDependencies}} attribute) a version of the 
> [{{android-versions}} npm|https://npm.im/android-versions] which doesn't 
> support Android SDK level 27, which was officially released in the last month.
> This omission prevents the use of {{cordova run android --emulator -d}} if 
> API level 27 is installed, which is the default SDK for a new installation of 
> Android Studio.  It also contributed to the error seen in CB-13571, though 
> that will prevent the same error from occurring in the future if an 
> additional SDK is released and not included in {{android-versions}}.
> While the latest version of {{android-versions}} (currently 1.3.0) does 
> support level 27 (now, thanks to [this recent 
> commit|https://github.com/dvoiss/android-versions/commit/230957205eeb26e569096251a32179e88a28acfc]),
>  the fact that it is a so-called "bundled dependency" means the current 
> version (1.2.1) is baked into the {{cordova-android}} installation tarball, 
> and won't automatically respect the caret version range (`^1.2.1`) listed in 
> {{cordova-android}}`s {{package.json}}, despite the lack of a 
> {{package-lock.json}} (or otherwise).
> Bumping the version of {{android-versions}} in {{cordova-android}}'s 
> {{package.json}} to 1.3.0 will enable the emulator to work with API level 27 
> (even if there _could_ be other reasons that API level 27 causes problems).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to