[
https://issues.apache.org/jira/browse/CB-13825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344649#comment-16344649
]
ASF GitHub Bot commented on CB-13825:
-------------------------------------
tripodsan commented on issue #46: CB-13825: (osx) Update node dependencies
URL: https://github.com/apache/cordova-osx/pull/46#issuecomment-361505208
sorry, but this is the wrong solution. adding the node_modules directly to
the repository is wrong. they need to come in via package.json.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Outdated node_modules
> ---------------------
>
> Key: CB-13825
> URL: https://issues.apache.org/jira/browse/CB-13825
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-osx
> Affects Versions: 4.1.0
> Reporter: Alberto Lalama
> Assignee: Tobias Bocanegra
> Priority: Major
>
> Commit [f7db769af|https://github.com/apache/cordova-osx/pull/43] updated
> cordova-common to v2.1.0 without updating node_modules. This means that
> pinning cordova-osx to the github repo in config.xml fails to install plugins
> with the following error:
> Installing "cordova-plugin-whitelist" for osx
> Failed to install 'cordova-plugin-whitelist':TypeError: Cannot read property
> 'get' of undefined
> at Api.addPlugin (platforms/osx/cordova/Api.js:187:25)
> at handleInstall (cordova-lib/src/plugman/install.js:611:6)
> at node_modules/cordova-lib/src/plugman/install.js:407:28
> at _fulfilled (node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done
> (node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch
> (node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at node_modules/cordova-lib/node_modules/q/q.js:509:49
> at flush (node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at _combinedTickCallback (internal/process/next_tick.js:131:7)
> at process._tickCallback (internal/process/next_tick.js:180:9)
> Failed to restore plugin "cordova-plugin-whitelist" from config.xml. You
> might need to try adding it again. Error: TypeError: Cannot read property
> 'get' of undefined
>
> A straightforward solution would be to update node_modules (cordova-ios seems
> to do this regularly). Could we use a dependency manager (e.g. yarn)? Any
> other suggestions?
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
