[
https://issues.apache.org/jira/browse/CB-13829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355484#comment-16355484
]
ASF GitHub Bot commented on CB-13829:
-------------------------------------
janpio commented on issue #246: CB-13829 Fix tests that were broken since
CB-13237
URL: https://github.com/apache/cordova-windows/pull/246#issuecomment-363780207
https://github.com/apache/cordova-windows/commit/dd91933d7030f6f0bb207a676968c4fdad9e3691
has nothing to do with this, it was just a commit of the release process that
is documented here:
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#update-and-pin-dependencies
It had to be reverted as the release process was canceled as I discovered the
failing tests and breaking changes (which requires a 6.0 release instead of a
5.1 I was working on).
The culprit for the failing tests is in
https://issues.apache.org/jira/browse/CB-13237 /
https://github.com/apache/cordova-windows/commit/c1dfc77ddf866b4872330eb2b8874ede05daddcd
but wasn't noticed as earlier `jasmine-node` was replaced by `jasmine` which
doesn't have the same command line params, which caused the tests to fail
silently and not to be run at all via
https://github.com/apache/cordova-windows/commit/1c6d245fbb10ab71c77eed6a73989827042422f5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix tests that were broken since CB-13237
> -----------------------------------------
>
> Key: CB-13829
> URL: https://issues.apache.org/jira/browse/CB-13829
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Affects Versions: 6.0.0
> Reporter: Jan Piotrowski (Sujan)
> Assignee: Jan Piotrowski (Sujan)
> Priority: Major
>
> CB-13237 introduced a major breaking change (by default the projects built
> are not Windows10/UWP and not 8.1 any more) and also broke the e2e-tests in
> the process (which wasn't noticed because the running of tests was broken
> even before by the switch from jasmine-node to jasmine and so CI didn'T
> report the test breakage).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
