[
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356839#comment-16356839
]
ASF GitHub Bot commented on CB-10893:
-------------------------------------
janpio commented on a change in pull request #124: CB-10893: (android) Allow
setting status bar color on Android splashscreen
URL:
https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r166910720
##########
File path: src/android/SplashScreen.java
##########
@@ -307,12 +310,29 @@ public void run() {
// Create and show the dialog
splashDialog = new Dialog(context,
android.R.style.Theme_Translucent_NoTitleBar);
- // check to see if the splash screen should be full screen
+ splashWindow = splashDialog.getWindow();
+ // check to see if the splash screen should be full screen
Review comment:
fix indentation here please (space instead of tabs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Allow setting status bar color on Android splashscreen
> ------------------------------------------------------
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-splashscreen
> Environment: Android
> Reporter: Martin Buchalik
> Priority: Major
>
> When creating a custom Android theme, you can also set a status bar
> background color.
> The splash screen doesn't seem to use the application's theme - the status
> bar becomes black while displaying the splash screen image (no matter which
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash
> screen image is displayed. Alternatively, inherit the application's status
> bar settings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
