[
https://issues.apache.org/jira/browse/CB-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358516#comment-16358516
]
Jan Piotrowski (Sujan) commented on CB-13834:
---------------------------------------------
(For documentation: This is a reply to something [~brodybits] posted as a
comment on the temporary PR he opened at Github)
> My comments are automatically reflected ...
Not really, as [~githubbot] is posting those here.
> @janpio would you consider reverting CB-12499 for now to unblock the badly
> needed cordova-windows release?
Not just like that, as this probably was added because of a reason - which
would mean releasing a known broken version as 6.0.0 again.
As I don't understand what CB-12499 does, I also can not assess if this is a
breaking change or not.
Do you know more about what CB-12499 does or solves?
[~sruthakeerthik] or [~daserge] can you maybe help out here about CB-12499 and
if it would be valid to exclude this temporarily for 6.0.0 and try again for
6.0.1?
> Fix tests failure with VS17 caused by CB-12499
> ----------------------------------------------
>
> Key: CB-13834
> URL: https://issues.apache.org/jira/browse/CB-13834
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
> Reporter: Jan Piotrowski (Sujan)
> Priority: Major
>
> The file `Default.rd.xml` introduced by CB-12499 is unfortunately causing
> test failures on AppVeyor when Visual Studio 2017 is used to build with
> params `--release --bundle --archs="x64 x86 arm"`.
>
> {code:java}
> Started
> Creating Cordova Windows Project:
> Path: testcreate 応用
> Namespace: com.test.app
> Name: 応用
> Windows project created with [email protected]
> Building project: C:\projects\cordova-windows\testcreate
> 応用\CordovaApp.Windows10.jsproj
> Configuration : release
> Platform : x64
> Patching 10 in prebuild event...
> Injected base.js reference to the www/index.html
> Removing /(
> *)(<script\s+(?:type="text\/javascript"\s+)?src="\/\/Microsoft.WinJS.2.0\/js\/base.js">\s*<\/script>)(\s*)/
> from www/index.html
> Removing /(
> *)(<script\s+(?:type="text\/javascript"\s+)?src="\/\/Microsoft.Phone.WinJS.2.1\/js\/base.js">\s*<\/script>)(\s*)/
> from www/index.html
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\build\windows\release\x64\win10\CordovaApp.Windows10_1.0.0.0_x64.appx
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\build\windows\release\x64\win10\Upload\CordovaApp.Windows10_1.0.0.0_x64.appx
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_Test\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
> CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_x64_bundle.appxupload
> Your package has been successfully created.
> Building project: C:\projects\cordova-windows\testcreate
> 応用\CordovaApp.Windows10.jsproj
> Configuration : release
> Platform : x86
> Patching 10 in prebuild event...
> C:\Program Files
> (x86)\MSBuild\Microsoft\VisualStudio\v14.0\AppxPackage\Microsoft.AppXPackage.Targets(2975,5):
> error MSB3231: Unable to remove directory
> "build\windows\bld\PackageUploadLayout\". The process cannot access the file
> 'Default.rd.xml' because it is being used by another process.
> [C:\projects\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj]
> C:\projects\cordova-windows\testcreate 応用\cordova\node_modules\q\q.js:155
> throw e;
> ^
> Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed
> with exit code 1
> at ChildProcess.whenDone (C:\projects\cordova-windows\testcreate
> 応用\cordova\node_modules\cordova-common\src\superspawn.js:169:23)
> at emitTwo (events.js:106:13)
> at ChildProcess.emit (events.js:191:7)
> at maybeClose (internal/child_process.js:920:16)
> at Process.ChildProcess._handle.onexit
> (internal/child_process.js:230:5){code}
> Afaik this is the only test that is "touching" that file (--release and
> Windows 10), so this might be a general problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
