[
https://issues.apache.org/jira/browse/CB-13854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360227#comment-16360227
]
ASF GitHub Bot commented on CB-13854:
-------------------------------------
macdonst closed pull request #312: CB-13854(ios): fix Camera opens in portrait
orientation on iphones
URL: https://github.com/apache/cordova-plugin-camera/pull/312
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/ios/CDVCamera.m b/src/ios/CDVCamera.m
index 37b4ec84..c71de054 100644
--- a/src/ios/CDVCamera.m
+++ b/src/ios/CDVCamera.m
@@ -206,6 +206,7 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
[weakSelf displayPopover:pictureOptions.popoverOptions];
weakSelf.hasPendingOperation = NO;
} else {
+ cameraPicker.modalPresentationStyle =
UIModalPresentationCurrentContext;
[weakSelf.viewController presentViewController:cameraPicker
animated:YES completion:^{
weakSelf.hasPendingOperation = NO;
}];
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Camera opens in portrait orientation on iphones
> -----------------------------------------------
>
> Key: CB-13854
> URL: https://issues.apache.org/jira/browse/CB-13854
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios, cordova-plugin-camera,
> cordova-plugin-media-capture
> Affects Versions: cordova-ios 4.5.0
> Environment: Cordova 7.1.0, Cordova 8.0.0
> iOS 9, 10, 11
> cordova-ios 4.5.x
>
> Reporter: Damian Ibbotson
> Priority: Major
>
> Using app in landscape on iphone and open the camera using a plugin
> (cordova-plugin-camera, cordova-plugin-media-capture). The camera opens in
> portrait mode. Dialogs to request permissions are therefore rotated, as is
> button text.
> Replicated with HelloCordova app with addition of cordova-plugin-camera.
> Using cordova-plugin-screen-orientation, we can see that an event to change
> the orientation to portrait-primary is fired when the camera is opened.
>
> Does not affect ipads.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
