[ 
https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360767#comment-16360767
 ] 

Jan Piotrowski (Sujan) commented on CB-13870:
---------------------------------------------

Re 1:
This can be solved by either a) changing the default to "10.0" or b) teach 
MsBuildTools.js about "UAP".

Re 2:
Not actually that relevant and important, but rewriting to be version 
independent would probably be a good idea.

Re 3:
This is more tricky. The current code assumes that the VS version and MSBuild 
versions are the same (15.0 for the time of when this was added: 
https://github.com/apache/cordova-windows/pull/237). But now VS is 15.5 and 
MSBuild is still 15.0. As there is an exact comparison, this does not work any 
more: 
https://github.com/apache/cordova-windows/blob/656ef073f417d59e32a123aa1fc84d3149378b52/template/cordova/lib/MSBuildTools.js#L131

> `cordova requirements` is broken since change to default=UAP and with modern 
> tooling
> ------------------------------------------------------------------------------------
>
>                 Key: CB-13870
>                 URL: https://issues.apache.org/jira/browse/CB-13870
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: Jan Piotrowski (Sujan)
>            Assignee: Jesse MacFadyen
>            Priority: Major
>
> check_reqs.js 
> 1. doesn't know about "UAP", only "10.0"
> 2. doesn't know about VS2017 (so error messages are wrong)
> 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to