[ 
https://issues.apache.org/jira/browse/CB-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362827#comment-16362827
 ] 

ASF GitHub Bot commented on CB-13861:
-------------------------------------

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365357575
 
 
   So I installed my branch which is giving me errors on running the test. 
   
   On `cordova platform add ...` it creates a `CordovaApp.Windows10.jsproj` 
file with:
   ```
       <PropertyGroup>
           <TargetPlatformIdentifier>UAP</TargetPlatformIdentifier>
           <TargetPlatformVersion>10.0.16299.0</TargetPlatformVersion>
           <TargetPlatformMinVersion>10.0.10240.0</TargetPlatformMinVersion>
           <MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
           <UapDefaultAssetScale>100</UapDefaultAssetScale>
       </PropertyGroup>
   ```
   
   So it updates the `TargetPlatformVersion` to the current version somewhere.
   
   Yes, there is some code for that in `prepare.js` and this is actually 
executed during `cordova platform add ...`.
   
   Which means that the tests should probably/maybe do something similar 
instead of this PR here, right? This PR is only making it possible to run the 
tests with a very specific setup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update TargetPlatformVersion to 10.0.10586.0
> --------------------------------------------
>
>                 Key: CB-13861
>                 URL: https://issues.apache.org/jira/browse/CB-13861
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: Jesse MacFadyen
>            Assignee: Jesse MacFadyen
>            Priority: Major
>
> For VS2017 Windows 10 projects we need to update TargetPlatformVersion to 
> 10.0.10586.0
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to