ASF GitHub Bot commented on CB-13875:

janpio commented on a change in pull request #254: [WIP] CB-13875 add `prepare` 
script that can be called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254#discussion_r167985739

 File path: template/cordova/prepare
 @@ -0,0 +1,61 @@
+#!/usr/bin/env node
+       Licensed to the Apache Software Foundation (ASF) under one
+       or more contributor license agreements.  See the NOTICE file
+       distributed with this work for additional information
+       regarding copyright ownership.  The ASF licenses this file
+       to you under the Apache License, Version 2.0 (the
+       "License"); you may not use this file except in compliance
+       with the License.  You may obtain a copy of the License at
+         http://www.apache.org/licenses/LICENSE-2.0
+       Unless required by applicable law or agreed to in writing,
+       software distributed under the License is distributed on an
+       KIND, either express or implied.  See the License for the
+       specific language governing permissions and limitations
+       under the License.
+var Api = require('./Api');
+var nopt = require('nopt');
+var path = require('path');
+var ConfigParser = require('cordova-common').ConfigParser;
+// Support basic help commands
+if(['--help', '/?', '-h', 'help', '-help', '/help'].indexOf(process.argv[2]) 
>= 0) {
+    console.log('Usage: \n    prepare\n');
+    process.exit(0);
+// Do some basic argument parsing
+var opts = nopt({
+    'verbose' : Boolean,
+    'silent' : Boolean
+}, { 'd' : '--verbose' });
+// Make buildOptions compatible with PlatformApi clean method spec
+opts.argv = opts.argv.original;
+// Skip cleaning prepared files when not invoking via cordova CLI.
+opts.noPrepare = true;
+var projectRoot = path.join(__dirname, '..');
+var project = {
 Review comment:
   this is pretty ugly here, but `prepare` is the only one of the "main" 
commands that takes a `project` as a param so I had to improvise.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> `npm run test-e2e` is highly platform dependent as `prepare` step is not run
> ----------------------------------------------------------------------------
>                 Key: CB-13875
>                 URL: https://issues.apache.org/jira/browse/CB-13875
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: Jan Piotrowski (Sujan)
>            Assignee: Jan Piotrowski (Sujan)
>            Priority: Major
> When running `npm run test-e2e` you have to have the Windows SDK with the 
> exact version that is mentioned in `TargetPlatformVersion` (which oldest one 
> in the template) installed for it to succeed.
> For actual projects, this is updated with the newest/available one on project 
> creation.
> For this to properly work in tests, `prepare` has also to be executed in the 
> e2e tests.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to