[ 
https://issues.apache.org/jira/browse/CB-13883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365726#comment-16365726
 ] 

ASF GitHub Bot commented on CB-13883:
-------------------------------------

janpio opened a new pull request #261: CB-13883 Visual Studio 2017 support 
URL: https://github.com/apache/cordova-windows/pull/261
 
 
   This reverts commit b5ec6350b4ba34ce7b5778f82fe1135f6899f5ee.
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist
   is intended as a quick reference, for complete details please see our 
Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   
   ### What does this PR do?
   
   Adds support for VS2017 (15.5) during the MSBuild selection
   
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Proper Visual Studio 2017 support
> ---------------------------------
>
>                 Key: CB-13883
>                 URL: https://issues.apache.org/jira/browse/CB-13883
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: Jan Piotrowski (Sujan)
>            Assignee: Jan Piotrowski (Sujan)
>            Priority: Major
>
> VS2017 only works by chance and "abusing" the `VSINSTALLDIR` env variable. 
> Add proper support without needing this hack.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to