Ams commented on CB-13865:


I am trying to implement the change and I need to figure out how to run the 
test cases.


For tests/ios: I figured it out using the commands below:

cd tests/ios && npm install && npm test


However, there is a file called tests.js: (tests/tests.js) this file has the 
javascript tests for the function I need such as window.onorientationchange. 
However, I do not know how to run those tests. I tried the commands below but 
they do nothing.

cd tests && npm install && npm test

Output: Error: no test specified


> Making CameraPopover for imagePicker bigger on Ipad
> ---------------------------------------------------
>                 Key: CB-13865
>                 URL: https://issues.apache.org/jira/browse/CB-13865
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-camera
>            Reporter: Ams
>            Priority: Major
>             Fix For: Master
> The popover for imagePicker from gallery is way too small and people complain 
> about not being able to see images before selecting them.
> The fix is simple:
> Adding this line to willShowViewController method will set it to 960 by 960 
> or as big as the screen widht/height
> [viewController setPreferredContentSize:CGSizeMake(960,960)];
> It should be added right in the if statement:
> if([navigationController isKindOfClass:[UIImagePickerController class]]){

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to