ASF GitHub Bot commented on CB-13828:

stevengill commented on a change in pull request #170: CB-13828: Improve 
URL: https://github.com/apache/cordova-coho/pull/170#discussion_r170132668

 File path: docs/platforms-release-process.md
 @@ -86,30 +157,46 @@ Ensure all dependencies and subdependencies have 
Apache-compatible licenses.
     coho check-license -r android
 ## Prepare Release
-Increase the version within package.json using SemVer, and remove the `-dev` 
+### Remove the `-dev` suffix from version
+This command removes `-dev` from the `version` entry in `package.json`:
     for l in cordova-android; do ( cd $l; v="$(grep '"version"' package.json | 
cut -d'"' -f4)"; if [[ $v = *-dev ]]; then v2="${v%-dev}"; echo "$l: Setting 
version to $v2"; sed -i '' -E 's/version":.*/version": "'$v2'",/' package.json; 
fi) ; done
-In `cordova-android`, also remember to bump the version in 
+Note: This command [doesn't actually 
work](https://issues.apache.org/jira/browse/CB-13809). You can also replace 
`-dev` manually of course.
-If the changes merit it, manually bump the major / minor/ patch version in 
`package.json`. View the changes via:
+Note: In `cordova-android`, also remember to handle the version in 
 Review comment:
   The remove dev part is split from the other version stuff because we use the 
version you set in package.json when writing to releasenotes. After you remove 
dev you may manually change the versionwhen reviewing commits in case you want 
a patch/minor/major release. This happens right before we run the update 
releasenotes command

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Improve cordova-coho/docs
> -------------------------
>                 Key: CB-13828
>                 URL: https://issues.apache.org/jira/browse/CB-13828
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-coho
>            Reporter: Jan Piotrowski (Sujan)
>            Priority: Major
> /docs in the `cordova-coho` repo is effectively the contributor documentation 
> of Cordova. It could use some improvements right now.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to