ASF GitHub Bot commented on CB-13984:

stevengill closed pull request #264: CB-13984: (ios) Fix toolbar navigation 
buttons always being hidden
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/264

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/ios/CDVInAppBrowser.m b/src/ios/CDVInAppBrowser.m
index a581472dd..56d227b72 100644
--- a/src/ios/CDVInAppBrowser.m
+++ b/src/ios/CDVInAppBrowser.m
@@ -654,7 +654,6 @@ - (void)createViews
     } else {
       [self.toolbar setItems:@[self.closeButton, flexibleSpaceButton, 
self.backButton, fixedSpaceButton, self.forwardButton]];
-    [self.toolbar setItems:@[self.closeButton, flexibleSpaceButton]];
     self.view.backgroundColor = [UIColor grayColor];
     [self.view addSubview:self.toolbar];


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Fix issue with toolbar navigation buttons always being hidden on iOS
> --------------------------------------------------------------------
>                 Key: CB-13984
>                 URL: https://issues.apache.org/jira/browse/CB-13984
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-inappbrowser
>            Reporter: Rasim Kanca
>            Assignee: jcesarmobile
>            Priority: Major
> In CB-13409, the functionality to hide the toolbar navigation buttons was 
> added for iOS through the *hidenavigationbuttons* property. Unfortunately, in 
> the iOS code, after checking whether the property is defined and what it is, 
> it defaults to hiding the buttons completely ignoring the value of the 
> property.
> The line in question can be viewed 
> [here|https://github.com/apache/cordova-plugin-inappbrowser/commit/8711ee3f211bf84913ae86f81e5e0e548d1c8015#diff-aa3201a8ef3df73e28e8979eaa6e228eR657].
>  There is a pull request that contains a commit with a fix in [this pull 
> request|https://github.com/apache/cordova-plugin-inappbrowser/pull/260].

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to