[
https://issues.apache.org/jira/browse/CB-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443328#comment-16443328
]
ASF GitHub Bot commented on CB-14038:
-------------------------------------
jcesarmobile commented on issue #437: CB-14038 (android): fix false positive
detecting project type
URL: https://github.com/apache/cordova-android/pull/437#issuecomment-382559626
As I said, my idea was to just add a quick simple fix to avoid the false
positives just by setting `isAndroidStudioProject ` to true, but in the end it
wasn't as simple as I had to delete tests, and update some test to test the
Android Studio case, and then delete the sample Eclipse project.
I can continue deleting code that is now irrelevant, which will lead to
delete more test, and to delete more code again, but then it won't be quick nor
simple.
There are also a lot of `options.android_studio === true` that are also
irrelevant, and I could just delete that option as it's always true, and then
I'll have to modify the tests to not use that option as it won't exist.
I think that kind of refactor can wait for a future release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> cordova-android false positive detecting project type
> -----------------------------------------------------
>
> Key: CB-14038
> URL: https://issues.apache.org/jira/browse/CB-14038
> Project: Apache Cordova
> Issue Type: Bug
> Reporter: jcesarmobile
> Priority: Major
>
> It sometimes thinks the project has Eclipse format, but all the projects are
> Android Studio projects now
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
