[
https://issues.apache.org/jira/browse/CB-14039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467027#comment-16467027
]
ASF GitHub Bot commented on CB-14039:
-------------------------------------
shazron closed pull request #364: CB-14039: Inputs type text don't work on iOS
URL: https://github.com/apache/cordova-ios/pull/364
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/CordovaLib/Classes/Private/Plugins/CDVGestureHandler/CDVGestureHandler.m
b/CordovaLib/Classes/Private/Plugins/CDVGestureHandler/CDVGestureHandler.m
index 242ac55b3..34ed46339 100644
--- a/CordovaLib/Classes/Private/Plugins/CDVGestureHandler/CDVGestureHandler.m
+++ b/CordovaLib/Classes/Private/Plugins/CDVGestureHandler/CDVGestureHandler.m
@@ -37,13 +37,13 @@ - (void)applyLongPressFix
self.lpgr = [[UILongPressGestureRecognizer alloc] initWithTarget:self
action:@selector(handleLongPressGestures:)];
self.lpgr.minimumPressDuration = 0.45f;
- self.lpgr.allowableMovement = 100.0f;
+ self.lpgr.allowableMovement = 200.0f;
// 0.45 is ok for 'regular longpress', 0.05-0.08 is required for '3D Touch
longpress',
// but since this will also kill onclick handlers (not ontouchend) it's
optional.
if ([self.commandDelegate.settings
objectForKey:@"suppresses3dtouchgesture"] &&
[[self.commandDelegate.settings
objectForKey:@"suppresses3dtouchgesture"] boolValue]) {
- self.lpgr.minimumPressDuration = 0.05f;
+ self.lpgr.minimumPressDuration = 0.15f;
}
NSArray *views = self.webView.subviews;
@@ -64,11 +64,7 @@ - (void)applyLongPressFix
- (void)handleLongPressGestures:(UILongPressGestureRecognizer*)sender
{
- if ([sender isEqual:self.lpgr]) {
- if (sender.state == UIGestureRecognizerStateBegan) {
- NSLog(@"Ignoring a longpress in order to suppress the magnifying
glass.");
- }
- }
+
}
@end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Inputs type text don't work on iOS
> ----------------------------------
>
> Key: CB-14039
> URL: https://issues.apache.org/jira/browse/CB-14039
> Project: Apache Cordova
> Issue Type: Bug
> Reporter: Jason Glez
> Priority: Major
>
> h3. PhoneGap CLI, node & npm versions
> PhoneGap CLI Version: 8.0.0
> Xcode Version: 9.3
> Node Version: 8.11.1
> NPM Version: 5.8.0
> Git Version: 2.16.3
> ios-sim Version: 6.1.2
> Using the following preferences in config.xml all the inputs type "text" stop
> working and cannot be clickable.
> <preference name="SuppressesLongPressGesture" value="true" /> <preference
> name="Suppresses3DTouchGesture" value="true" />
> Devices tested:
> * iPhone X 11.3 (Emulator)
> * iPhone 6 10.2.1 (Physical device)
> h3. Expected Behaviour
> * The inputs are clickable and the user can write.
> h3. Actual Behaviour
> * The inputs are not clickable and the user cannot write
> * Note: Sometimes the application opens the keyboard, but it's really
> difficult to get.
> h3. Steps to Reproduce
> * Create a new project: phonegap create myApp
> * Add some inputs type text in the HTML
> * Run the application: phonegap run ios
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
