[
https://issues.apache.org/jira/browse/CB-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471565#comment-16471565
]
ASF GitHub Bot commented on CB-14061:
-------------------------------------
panoti commented on issue #269: CB-14061: (android) comply with RFC 3986 for
custom URL scheme handling
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/269#issuecomment-388282959
this PR is necessary for ionic using with auth0. [Example
code](https://github.com/auth0-samples/auth0-ionic3-samples/tree/master/01-Login)
Auth0 use `PACKAGE_ID` as `URL_SCHEME` (` <variable name="URL_SCHEME"
value="com.auth0.ionic" />`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> cordova-plugin-inappbrowser should allow more custom URL schemes
> ----------------------------------------------------------------
>
> Key: CB-14061
> URL: https://issues.apache.org/jira/browse/CB-14061
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
> Affects Versions: 3.0.0
> Reporter: Tim Brust
> Priority: Minor
>
> The current Android regexp (^[a-z]*://.*?$)
> (https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L1115)
> does not allow schemes like d2d or develop+d2d.
> According to RFC 3986 (quoting) "Scheme names consist of a sequence of
> characters beginning with a letter and followed by any combination of
> letters, digits, plus ("+"), period ("."), or hyphen ("-")"
> (https://tools.ietf.org/html/rfc3986#section-3.1)
>
> The regexp should be expanded to allow numbers, plus, periods and hyphens.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
