[
https://issues.apache.org/jira/browse/CB-14076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474844#comment-16474844
]
ASF GitHub Bot commented on CB-14076:
-------------------------------------
codecov-io commented on issue #365: CB-14076: (ios) Setting UIWebViewDelegate
on CDVWebViewEngineProtocol doesn't work
URL: https://github.com/apache/cordova-ios/pull/365#issuecomment-388978333
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/365?src=pr&el=h1)
Report
> Merging
[#365](https://codecov.io/gh/apache/cordova-ios/pull/365?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/cordova-ios/commit/634176b36d5029abd34cba9fefea164d25a692de?src=pr&el=desc)
will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/365?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #365 +/- ##
=======================================
Coverage 63.99% 63.99%
=======================================
Files 14 14
Lines 1697 1697
Branches 286 286
=======================================
Hits 1086 1086
Misses 611 611
```
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/365?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/365?src=pr&el=footer).
Last update
[634176b...d24fe18](https://codecov.io/gh/apache/cordova-ios/pull/365?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Setting UIWebViewDelegate via updateWithInfo doesn't work
> ---------------------------------------------------------
>
> Key: CB-14076
> URL: https://issues.apache.org/jira/browse/CB-14076
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
> Affects Versions: cordova-ios 4.5.0
> Reporter: Dan Polivy
> Assignee: Suraj Pindoria
> Priority: Major
>
> I have an existing Cordova app where I have manually modified
> {{MainViewController.m}} to add my own {{UIWebViewDelegate}} implementation
> -- however, I'd like to do this the "right" way and use a plugin (so I can
> truly treat the platform code as a build artifact).
> From [this
> guide|https://github.com/apache/cordova-ios/blob/master/guides/Setting%20Delegates%2C%20Preferences%20and%20Script%20Message%20Handlers%20in%20the%20WebView.md],
> I see that I should be able to set my {{UIWebViewDelegate}} from my plugin
> code; however, this isn't working. My implementation is not getting called.
> In [the
> code|https://github.com/apache/cordova-ios/blob/3507af4ac68ed13cfb4d8ecfd0e91e747a9c6875/CordovaLib/Classes/Private/Plugins/CDVUIWebViewEngine/CDVUIWebViewEngine.m#L179],
> it appears to be always using the {{CDVViewController}} as the delegate, no
> matter what is passed in.
> Is this a bug? Am I just doing it wrong? What's the correct way to do this?
> My scenario here is to trap the {{didFailLoadWithError}} event for some
> special handling (our Cordova app uses remote resources, and I want to allow
> a retry option if they don't load). This is working just fine when I modify
> the application source directly.
> (Also posted on SO:
> https://stackoverflow.com/questions/50162345/how-do-you-implement-uiwebviewdelegate-from-a-cordova-ios-plugin)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
