[ 
https://issues.apache.org/jira/browse/CB-14065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476740#comment-16476740
 ] 

ASF GitHub Bot commented on CB-14065:
-------------------------------------

dpogue closed pull request #612: CB-14065: Drop support for Node 4 and add Node 
10 to CI
URL: https://github.com/apache/cordova-lib/pull/612
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index cc0eebf34..dc58f6990 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,12 +2,12 @@ language: node_js
 sudo: false
 git:
   depth: 10
+
 node_js:
-  - "4"
   - "6"
   - "8"
-# we don't test with npm 2.x
-before_install: if [[ `npm -v` < 3 ]]; then npm i -g npm@3; fi
+  - "10"
+
 install:
   - npm install
   # Workaround for npm/npm#10343 when dependency of linked module is moved to 
dependent
diff --git a/appveyor.yml b/appveyor.yml
index 4c3d2982b..ad552882e 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -3,10 +3,10 @@
 
 environment:
   matrix:
-  - nodejs_version: "4"
   - nodejs_version: "6"
   - nodejs_version: "8"
-  
+  - nodejs_version: "10"
+
 install:
   - ps: Install-Product node $env:nodejs_version
   - npm install
diff --git a/package.json b/package.json
index 9b964ee50..4140abb1c 100644
--- a/package.json
+++ b/package.json
@@ -14,7 +14,7 @@
   },
   "main": "cordova-lib.js",
   "engines": {
-    "node": ">=4.0.0"
+    "node": ">=6.0.0"
   },
   "dependencies": {
     "aliasify": "^2.1.0",


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Remove Node 4 from CI - cordova-lib
> -----------------------------------
>
>                 Key: CB-14065
>                 URL: https://issues.apache.org/jira/browse/CB-14065
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: cordova-lib
>            Reporter: Darryl Pogue
>            Assignee: Darryl Pogue
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to